From 25467a1f66d083fa3c6997b2ffead81eb57defd9 Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Tue, 6 Nov 2018 15:02:47 +0100 Subject: [PATCH] Bug 21771: (Follow-up) Revert the shift statement Content-Type: text/plain; charset=utf-8 Obviously you should never shift an items from an array if you need that item later on :) Signed-off-by: Marcel de Rooy Tested with entering userid as well as entering email.. --- opac/opac-password-recovery.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/opac/opac-password-recovery.pl b/opac/opac-password-recovery.pl index 8a26147..2b39e52 100755 --- a/opac/opac-password-recovery.pl +++ b/opac/opac-password-recovery.pl @@ -75,7 +75,8 @@ if ( $query->param('sendEmail') || $query->param('resendEmail') ) { elsif ( $borrower = $search_results->next() ) { # One matching borrower my @emails = grep { $_ } ( $borrower->email, $borrower->emailpro, $borrower->B_email ); - my $firstNonEmptyEmail = shift @emails; + my $firstNonEmptyEmail; + $firstNonEmptyEmail = $emails[0] if @emails; # Is the given email one of the borrower's ? if ( $email && !( grep /^$email$/i, @emails ) ) { -- 2.1.4