From a4a2f678cea375d9fc3deb6404bd23ad49305c90 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Wed, 7 Nov 2018 19:01:16 +0000 Subject: [PATCH] Bug 21785: Add columns configuration to hold ratios report This patch adds column configuration to the hold ratios report DataTable. This patch also amends some JavaScript and markup related to some obsolete jQuery syntax: A hover function was being used to change an element's style on hover. It has been removed in favor of using a link and CSS> To test, apply the patch and view the hold ratios report using a ratio which will return multiple results. Confirm that DataTables controls work correctly: Paging, search, column visibility, export and print. Click a number in the "hold ratio" column of the table and verify that it populates the "hold ratio" field in the "refine results" form in the sidebar. Test setting default column configurations in Administration -> Columns settings. --- admin/columns_settings.yml | 23 +++++++++++ .../prog/en/modules/circ/reserveratios.tt | 44 +++++++++++----------- 2 files changed, 46 insertions(+), 21 deletions(-) diff --git a/admin/columns_settings.yml b/admin/columns_settings.yml index 1480019..b5847d5 100644 --- a/admin/columns_settings.yml +++ b/admin/columns_settings.yml @@ -598,6 +598,29 @@ modules: - columnname: action + holdsratios: + holds-ratios: + - + columnname: holds + - + columnname: items + - + columnname: holds_ratio + - + columnname: title + - + columnname: home_libraries + - + columnname: holding_libraries + - + columnname: location + - + columnname: itemtype + - + columnname: call_numbers + - + columnname: items_needed + opac: biblio-detail: holdingst: diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/reserveratios.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/reserveratios.tt index eb0efc7..d509ba9 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/reserveratios.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/reserveratios.tt @@ -4,6 +4,7 @@ [% USE AuthorisedValues %] [% USE Branches %] [% USE ItemTypes %] +[% USE ColumnsSettings %] [% SET footerjs = 1 %] [% INCLUDE 'doc-head-open.inc' %] Koha › Circulation › Hold ratios @@ -12,7 +13,8 @@ @@ -55,7 +57,7 @@

[% reserveloo.reservecount | html %]

[% reserveloo.itemcount | html %]

-

[% reserveloo.thisratio | html %]

+ [% reserveloo.thisratio | html %] [% INCLUDE 'biblio-default-view.inc' biblionumber = reserveloo.biblionumber %][% reserveloo.title | html %] [% IF ( reserveloo.subtitle ) %][% FOREACH subtitl IN reserveloo.subtitle %][% subtitl.subfield | html %][% END %][% END %][% IF ( reserveloo.author ) %] by [% reserveloo.author | html %][% END %] @@ -152,25 +154,25 @@ [% MACRO jsinclude BLOCK %] - [% INCLUDE 'calendar.inc' %] - [% INCLUDE 'datatables.inc' %] - [% END %] -- 2.1.4