Bugzilla – Attachment 8220 Details for
Bug 5698
Provide datepicker for sql reports runtime parameters
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Followup proposed for discussion
0001-Bug-5698-Followup-Add-date-picker-option-to-SQL-Runt.patch (text/plain), 3.11 KB, created by
Jonathan Druart
on 2012-03-16 10:57:07 UTC
(
hide
)
Description:
Followup proposed for discussion
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2012-03-16 10:57:07 UTC
Size:
3.11 KB
patch
obsolete
>From a901a946e0450507aca46b7aec9d90aa5459a7a8 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Fri, 16 Mar 2012 11:36:46 +0100 >Subject: [PATCH 1/1] Bug 5698: Followup: Add date picker option to SQL > Runtime Parameters > >Move html >--- > .../en/modules/reports/guided_reports_start.tt | 16 +++++++++++++++- > reports/guided_reports.pl | 13 +------------ > 2 files changed, 16 insertions(+), 13 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >index caf27f1..4c2dc00 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >@@ -486,7 +486,21 @@ canned reports and writing custom SQL reports.</p> > <h1>Enter parameters for report [% name %]:</h1> > [% IF ( notes ) %]<p>[% notes %]</p>[% END %] > [% FOREACH sql_param IN sql_params %] >- <p>[% sql_param.entry %]: [% sql_param.input %]</p> >+ [% IF sql_param.input == 'date' %] >+ <p> >+ [% sql_param.entry %]: <input id="date_[% sql_param_entry %]" type="text" value="" size="10" name="sql_params"> >+ <img id="date_picker_[% sql_param_entry %]" alt="Show Calendar" src="/intranet-tmpl/prog/en/lib/calendar/cal.gif"> >+ <script type="text/javascript"> >+ Calendar.setup( { >+ inputField : "date_[% sql_param_entry %]", >+ ifFormat : "%Y-%m-%d", >+ button : "date_picker_[% sql_param_entry %]" >+ } ); >+ </script> >+ </p> >+ [% ELSE %] >+ <p>[% sql_param.entry %]: [% sql_param.input %]</p> >+ [% END %] > [% END %] > <input type='submit' value='Run the report'/> > </form> >diff --git a/reports/guided_reports.pl b/reports/guided_reports.pl >index ce9370a..5d53791 100755 >--- a/reports/guided_reports.pl >+++ b/reports/guided_reports.pl >@@ -421,18 +421,7 @@ elsif ($phase eq 'Run this report'){ > my ($text,$authorised_value) = split /\|/,$split[$i*2+1]; > my $input; > if ($authorised_value eq "date") { >- $input = qq(<input id="date_$text" type="text" value="" size="10" name="sql_params"> >- <img id="date_picker_$text" alt="Show Calendar" src="/intranet-tmpl/prog/en/lib/calendar/cal.gif"> >- <script type="text/javascript"> >- Calendar.setup( >- { >- inputField : "date_$text", >- ifFormat : "%Y-%m-%d", >- button : "date_picker_$text" >- } >- ); >- </script> >- ); >+ $input = 'date'; > } > elsif ($authorised_value) { > my $dbh=C4::Context->dbh; >-- >1.7.7.3 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 5698
:
8136
|
8138
| 8220