Bugzilla – Attachment 82223 Details for
Bug 13654
Cannot place a hold for biblio with too many items to display unless viewing them all
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 13654: Show 'Place hold' when there are too many items?
Bug-13654-Show-Place-hold-when-there-are-too-many-.patch (text/plain), 1.42 KB, created by
Marcel de Rooy
on 2018-11-12 13:16:02 UTC
(
hide
)
Description:
Bug 13654: Show 'Place hold' when there are too many items?
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2018-11-12 13:16:02 UTC
Size:
1.42 KB
patch
obsolete
>From d7aef2a6f0314f0bf81e6f6b12ceb45ef1a6585c Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Mon, 12 Nov 2018 14:07:55 +0100 >Subject: [PATCH] Bug 13654: Show 'Place hold' when there are too many items? >Content-Type: text/plain; charset=utf-8 > >Currently, we do not show Place hold on opac-detail if there are too many items. The user can click View all items to refresh the detail page with all items. At that time we show Place hold (if possible). > >If we just show Place hold if there are too many items, clicking Place hold could perhaps generate a refusal but will probably most often save another click on View all items (which even seems to confuse some users). > >Test plan: >Pick a biblio with too many items or lower OpacMaxItemsToDisplay. >With this patch, you now see Place hold in the side bar. >--- > opac/opac-detail.pl | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/opac/opac-detail.pl b/opac/opac-detail.pl >index a7c24ef..bddb507 100755 >--- a/opac/opac-detail.pl >+++ b/opac/opac-detail.pl >@@ -672,7 +672,9 @@ if ( not $viewallitems and @items > $max_items_to_display ) { > $template->param( > too_many_items => 1, > items_count => scalar( @items ), >+ AllowOnShelfHolds => 1, #userfriendly assumption, no guarantee > ); >+ $norequests = 0; # userfriendly assumption, no guarantee > } else { > for my $itm (@items) { > my $item = Koha::Items->find( $itm->{itemnumber} ); >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13654
:
35656
| 82223