Bugzilla – Attachment 82238 Details for
Bug 21671
Koha/Patron/Modifications.t is failing randomly
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21671: Prevent Modifications.t to fail randomly
Bug-21671-Prevent-Modificationst-to-fail-randomly.patch (text/plain), 1.39 KB, created by
Jonathan Druart
on 2018-11-12 18:22:08 UTC
(
hide
)
Description:
Bug 21671: Prevent Modifications.t to fail randomly
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2018-11-12 18:22:08 UTC
Size:
1.39 KB
patch
obsolete
>From b8fdceb35021202a452c7f2f7acd001da461da7d Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 12 Nov 2018 15:20:33 -0300 >Subject: [PATCH] Bug 21671: Prevent Modifications.t to fail randomly > >If repeatable is set to 0 by TestBuilder, the tests will fail with: >t/db_dependent/Koha/Patron/Modifications.t .. 1/6 # Looks like you planned 20 tests but ran 9. > > # Failed test 'approve tests' > # at t/db_dependent/Koha/Patron/Modifications.t line 259. >[repeatable not set for attribute type and tried to add a new attribute for the same code]# Looks like your test exited with 255 just after 5. >--- > t/db_dependent/Koha/Patron/Modifications.t | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/t/db_dependent/Koha/Patron/Modifications.t b/t/db_dependent/Koha/Patron/Modifications.t >index 188808878d..decd9ac43d 100755 >--- a/t/db_dependent/Koha/Patron/Modifications.t >+++ b/t/db_dependent/Koha/Patron/Modifications.t >@@ -146,7 +146,7 @@ subtest 'approve tests' => sub { > { source => 'BorrowerAttributeType', value => { code => 'CODE_1' } } > ); > $builder->build( >- { source => 'BorrowerAttributeType', value => { code => 'CODE_2' } } >+ { source => 'BorrowerAttributeType', value => { code => 'CODE_2', repeatable => 1 } } > ); > my $verification_token = md5_hex( time().{}.rand().{}.$$ ); > my $valid_json_text >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21671
:
82238
|
89038
|
89300