Bugzilla – Attachment 82317 Details for
Bug 15836
Labels: Offer configuration option for splitting call numbers
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15836: Fix failing tests
Bug-15836-Fix-failing-tests.patch (text/plain), 2.22 KB, created by
Jonathan Druart
on 2018-11-13 17:39:59 UTC
(
hide
)
Description:
Bug 15836: Fix failing tests
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2018-11-13 17:39:59 UTC
Size:
2.22 KB
patch
obsolete
>From fe8ca2d086614a9a3d653bc250c7c638aa9f5224 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 13 Nov 2018 14:32:16 -0300 >Subject: [PATCH] Bug 15836: Fix failing tests > >--- > t/Labels_split_ccn.t | 2 +- > t/db_dependent/Koha/ClassSources.t | 3 +++ > 2 files changed, 4 insertions(+), 1 deletion(-) > >diff --git a/t/Labels_split_ccn.t b/t/Labels_split_ccn.t >index 936c883284..40d1e7d289 100755 >--- a/t/Labels_split_ccn.t >+++ b/t/Labels_split_ccn.t >@@ -51,7 +51,7 @@ foreach my $ccn (sort keys %$ccns) { > my (@parts, @expected); > ok($ccn, "ddcn: $ccn"); > ok(@expected = @{$ccns->{$ccn}}, "split expected to produce " . scalar(@expected) . " pieces"); >- ok(@parts = C4::Labels::Label::_split_ccn($ccn), "C4::Labels::Label::_split_ccn($ccn)"); >+ ok(@parts = C4::ClassSplitRoutine::Generic::split_callnumber($ccn), "split LCC ($ccn)"); > ok(scalar(@expected) == scalar(@parts), sprintf("%d of %d pieces produced", scalar(@parts), scalar(@expected))); > my $i = 0; > foreach my $unit (@expected) { >diff --git a/t/db_dependent/Koha/ClassSources.t b/t/db_dependent/Koha/ClassSources.t >index f188e0f946..c1772b1654 100644 >--- a/t/db_dependent/Koha/ClassSources.t >+++ b/t/db_dependent/Koha/ClassSources.t >@@ -33,18 +33,21 @@ $schema->storage->txn_begin; > my $builder = t::lib::TestBuilder->new; > my $class_sort_1 = $builder->build({ source=>'ClassSortRule' }); > my $class_sort_2 = $builder->build({ source=>'ClassSortRule' }); >+my $class_split = $builder->build({ source=>'ClassSplitRule' }); > my $nb_of_class_sources = Koha::ClassSources->search->count; > my $new_cs_1 = Koha::ClassSource->new({ > cn_source => 'source_1', > description => 'a_test_1', > used => '1', > class_sort_rule => $class_sort_1->{class_sort_rule},#'sort_rule_1', >+ class_split_rule => $class_split->{class_split_rule}, > })->store; > my $new_cs_2 = Koha::ClassSource->new({ > cn_source => 'source_2', > description => 'a_test_2', > used => '0', > class_sort_rule => $class_sort_2->{class_sort_rule},#'sort_rule_1', >+ class_split_rule => $class_split->{class_split_rule}, > })->store; > > is( $new_cs_1->cn_source, 'source_1', 'Adding a new classification should have set the cn_source'); >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15836
:
76691
|
76692
|
76693
|
76694
|
76695
|
76696
|
77061
|
77079
|
77306
|
78791
|
78793
|
78795
|
78796
|
78798
|
78799
|
79029
|
80339
|
80340
|
80341
|
80342
|
80343
|
80344
|
80345
|
80346
|
80347
|
80548
|
80549
|
80550
|
80551
|
80552
|
80553
|
80554
|
80555
|
80556
|
81033
|
81034
|
81035
|
81036
|
81037
|
81038
|
81039
|
81040
|
81041
|
81627
|
81628
|
81629
|
81630
|
81631
|
81632
|
81633
|
81634
|
81635
|
82110
|
82112
|
82113
|
82118
|
82119
|
82120
|
82289
|
82290
|
82291
|
82292
|
82293
|
82294
|
82295
|
82296
|
82297
|
82298
|
82299
|
82300
|
82301
|
82302
| 82317 |
82318
|
82319
|
82321