Bugzilla – Attachment 82370 Details for
Bug 21814
System preferences save button can be hidden by language menu
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21814: (follow-up) System preferences save button can be hidden by language menu
Bug-21814-follow-up-System-preferences-save-button.patch (text/plain), 1.61 KB, created by
Owen Leonard
on 2018-11-15 17:24:15 UTC
(
hide
)
Description:
Bug 21814: (follow-up) System preferences save button can be hidden by language menu
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2018-11-15 17:24:15 UTC
Size:
1.61 KB
patch
obsolete
>From 9cf739a46ee321b9d118857b87879d1cddff757f Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Thu, 15 Nov 2018 17:20:52 +0000 >Subject: [PATCH] Bug 21814: (follow-up) System preferences save button can be > hidden by language menu > >This follow-up implements the same change by defining a variable to be >used as the minimum height of the language footer navbar. A calculation >is done on this value to set the bottom margin of the main area of the >page. > >To test, apply the patch and rebuild the staff client CSS. Clear your >browser cache if necessary. View the system preferences page again and >confirm that the bug is still fixed. >--- > koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >index 31710ec..99e43a9 100644 >--- a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >+++ b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >@@ -2,6 +2,7 @@ > > $font-main: Arial, Verdana, Helvetica, sans-serif; > $font-monospace: "Courier New", Courier, monospace; >+$language-footer-min-height: 20px; > > @mixin default-button { > background: linear-gradient(to bottom, #FFFFFF 0%, #F7F7F7 35%, #E0E0E0 100%); >@@ -582,8 +583,8 @@ label, > } > > .main { >+ margin-bottom: $language-footer-min-height * 1.5; > margin-top: 1em; >- margin-bottom: 3em; > } > > #login_controls { >@@ -3311,6 +3312,8 @@ button, > } > > #changelanguage { >+ min-height: $language-footer-min-height; >+ > .dropdown-menu { > > li { > > a, >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21814
:
82243
|
82362
|
82370
|
82371
|
82372