Bugzilla – Attachment 82389 Details for
Bug 18677
issue_id is not added to accountlines for lost item fees
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18677: (QA follow-up) Trivial fixes to Chargelostitem.t
Bug-18677-QA-follow-up-Trivial-fixes-to-Chargelost.patch (text/plain), 1.96 KB, created by
Marcel de Rooy
on 2018-11-16 09:10:44 UTC
(
hide
)
Description:
Bug 18677: (QA follow-up) Trivial fixes to Chargelostitem.t
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2018-11-16 09:10:44 UTC
Size:
1.96 KB
patch
obsolete
>From 0c8f2124e90159cb67f1cd6897afa89d1749af88 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 16 Nov 2018 10:04:55 +0100 >Subject: [PATCH] Bug 18677: (QA follow-up) Trivial fixes to Chargelostitem.t >Content-Type: text/plain; charset=utf-8 > >Kind of funny that we did not touch this test here. But it passed! >Trivial fixes: >[1] Typo precessfee >[2] Typo the linked >[3] Add rollback > >Test plan: >Run t/db_dependent/Circulation/Chargelostitem.t >--- > t/db_dependent/Circulation/Chargelostitem.t | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/Circulation/Chargelostitem.t b/t/db_dependent/Circulation/Chargelostitem.t >index 7dc0fe3..93c7f98 100644 >--- a/t/db_dependent/Circulation/Chargelostitem.t >+++ b/t/db_dependent/Circulation/Chargelostitem.t >@@ -72,8 +72,8 @@ C4::Accounts::chargelostitem( $borrowernumber, $issue->{itemnumber}, '1.00'); > > my $accountline = Koha::Account::Lines->search( { borrowernumber => $borrowernumber, accounttype => 'PF' } )->next(); > >-is( int($accountline->amount), int($itemtype->{processfee}), "The accountline amount should be precessfee value " ); >-is( $accountline->itemnumber, $itemnumber1, "The accountline itemnumber should the linked with barcode '0101'" ); >+is( int($accountline->amount), int($itemtype->{processfee}), "The accountline amount should be processfee value " ); >+is( $accountline->itemnumber, $itemnumber1, "The accountline itemnumber should be linked with barcode '0101'" ); > is( $accountline->note, C4::Context->preference("ProcessingFeeNote"), "The accountline description should be 'test'" ); > > my $lost_ao = Koha::Account::Offsets->search( { type => 'Lost Item' } ); >@@ -81,3 +81,5 @@ is( $lost_ao->count, 1, 'Account offset of type "Lost Item" created' ); > > my $processing_fee_ao = Koha::Account::Offsets->search( { type => 'Processing Fee' } ); > is( $processing_fee_ao->count, 1, 'Account offset of type "Processing Fee" created' ); >+ >+$schema->storage->txn_rollback; >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18677
:
74022
|
74165
|
81133
|
81732
|
81823
|
81824
|
81976
|
81977
|
81978
|
82386
|
82387
|
82388
| 82389