From 72b29543f2aa8b96dcaf6dd733c2cb28cd9900bc Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Fri, 16 Nov 2018 07:01:39 -0500 Subject: [PATCH] Bug 21849: Two useless Koha::Account::Offset->new calls need attention Came across those calls in bug 20598 in _FixOverduesOnReturn Koha::Account::Offset->new( { debit_id => $accountline->id, type => 'Forgiven', amount => $amountoutstanding * -1, } ); This does nothing if you don't store data. Test Plan: 1) Apply this patch 2) Set up 2 items with overdue fines 3) Return one with dropbox mode 4) Note the dropbox account offset is created 5) Return one with full fine forgiveness 6) Note the forgiven account offset is created --- C4/Circulation.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/C4/Circulation.pm b/C4/Circulation.pm index 0999a970fd..4d252c6929 100644 --- a/C4/Circulation.pm +++ b/C4/Circulation.pm @@ -2339,7 +2339,7 @@ sub _FixOverduesOnReturn { type => 'Forgiven', amount => $amountoutstanding * -1, } - ); + )->store(); if (C4::Context->preference("FinesLog")) { &logaction("FINES", 'MODIFY',$borrowernumber,"Overdue forgiven: item $item"); @@ -2354,7 +2354,7 @@ sub _FixOverduesOnReturn { type => 'Dropbox', amount => $accountline->lastincrement * -1, } - ); + )->store(); if ( C4::Context->preference("FinesLog") ) { &logaction( "FINES", 'MODIFY', $borrowernumber, -- 2.17.2 (Apple Git-113)