Bugzilla – Attachment 82419 Details for
Bug 21844
Add callnumber to fines descriptions
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21844: Include itemcallnumber in lost ifne description
Bug-21844-Include-itemcallnumber-in-lost-ifne-desc.patch (text/plain), 1.63 KB, created by
Pierre-Marc Thibault
on 2018-11-16 21:19:46 UTC
(
hide
)
Description:
Bug 21844: Include itemcallnumber in lost ifne description
Filename:
MIME Type:
Creator:
Pierre-Marc Thibault
Created:
2018-11-16 21:19:46 UTC
Size:
1.63 KB
patch
obsolete
>From c382693e17b6f4a7ff262643471900be6d933ba3 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Thu, 15 Nov 2018 18:56:00 +0000 >Subject: [PATCH] Bug 21844: Include itemcallnumber in lost ifne description > >To test: > 1 - Make sure WhenLostChargeReplacementFee is set to charge > 2 - Find an item with a replacement cost (or default) and a call number > 3 - Checkout the item to a patron > 4 - Mark the item lost > 5 - View the fine - the description includes title and barcode > 6 - Apply patch > 7 - Check the item in > 8 - Check it out again > 9 - Mark it lost >10 - Note the fine inclues the callnumber > >Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> >--- > C4/Circulation.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index 0999a97..ef39633 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -3693,7 +3693,7 @@ sub LostItem{ > defined($fix) or warn "_FixOverduesOnReturn($borrowernumber, $itemnumber...) failed!"; # zero is OK, check defined > > if (C4::Context->preference('WhenLostChargeReplacementFee')){ >- C4::Accounts::chargelostitem($borrowernumber, $itemnumber, $issues->{'replacementprice'}, "Lost Item $issues->{'title'} $issues->{'barcode'}"); >+ C4::Accounts::chargelostitem($borrowernumber, $itemnumber, $issues->{'replacementprice'}, "Lost Item $issues->{'title'} $issues->{'barcode'} $issues->{'itemcallnumber'}"); > #FIXME : Should probably have a way to distinguish this from an item that really was returned. > #warn " $issues->{'borrowernumber'} / $itemnumber "; > } >-- >2.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21844
:
82373
|
82419
|
82727