Bugzilla – Attachment 82633 Details for
Bug 21644
UNIMARC XSLT display of 210 in intranet
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21644: better UNIMARC XSLT display of 210 in intranet
Bug-21644-better-UNIMARC-XSLT-display-of-210-in-in.patch (text/plain), 3.90 KB, created by
Marcel de Rooy
on 2018-11-26 10:43:06 UTC
(
hide
)
Description:
Bug 21644: better UNIMARC XSLT display of 210 in intranet
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2018-11-26 10:43:06 UTC
Size:
3.90 KB
patch
obsolete
>From 9e67ecd4e4c9fbaf65de966dd1547d0f633805dd Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Wed, 24 Oct 2018 14:23:02 +0200 >Subject: [PATCH] Bug 21644: better UNIMARC XSLT display of 210 in intranet >Content-Type: text/plain; charset=utf-8 > >In intranet default UNIMARC XSLT display of 210 is tricky. >It tests each subfield with a complex conditional prefix. >In OPAC default UNIMARC XSLT display 210 is simply displayed with a loop on all subfields. > >I propose to use the same code as OPAC in intranet. >It allows to display $f and removes strange middle-score character. > >Test plan: >1) Doni't apply patch >2) Use an UNIMARC database >3) Use default XSLT in all displays >4) Configure a framework to allow 210 subfields from 'a' to 'h' >5) Edit a record with this framework >6) In each 210 subfield enter its letter : $a a, $b b ... >7) Save record >8) Look at record in OPAC, you see : "Publication: a, b : c, d, e, f : g, h" >9) Look at record in intranet >10) You see : ""Publication: a, b : c, d - e : g, h >11) Apply patch >12) Look at record in intranet >13) You see : "Publication: a, b : c, d, e, f : g, h" > >Signed-off-by: Andreas Roussos <arouss1980@gmail.com> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >This patch makes intranet consistent with staff again on this area. >Note that we loose some punctuation like "- e". >--- > .../prog/en/xslt/UNIMARCslimUtils.xsl | 41 +++++++++------------- > 1 file changed, 16 insertions(+), 25 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/xslt/UNIMARCslimUtils.xsl b/koha-tmpl/intranet-tmpl/prog/en/xslt/UNIMARCslimUtils.xsl >index 48d50c5..c41777b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/xslt/UNIMARCslimUtils.xsl >+++ b/koha-tmpl/intranet-tmpl/prog/en/xslt/UNIMARCslimUtils.xsl >@@ -34,31 +34,22 @@ > <xsl:for-each select="marc:datafield[@tag=210]"> > <span> > <xsl:call-template name="addClassRtl" /> >- <xsl:value-of select="marc:subfield[@code='a']"/> >- <xsl:if test="marc:subfield[@code='b']"> >- <xsl:if test="marc:subfield[@code='a']">, </xsl:if> >- <xsl:value-of select="marc:subfield[@code='b']"/> >- </xsl:if> >- <xsl:if test="marc:subfield[@code='a' or @code='b']"> >- <xsl:if test="marc:subfield[@code='a']"> : </xsl:if> >- <xsl:value-of select="marc:subfield[@code='c']"/> >- </xsl:if> >- <xsl:if test="marc:subfield[@code='d']"> >- <xsl:if test="marc:subfield[@code='a' or @code='c']">, </xsl:if> >- <xsl:value-of select="marc:subfield[@code='d']"/> >- </xsl:if> >- <xsl:if test="marc:subfield[@code='e']"> >- <xsl:if test="marc:subfield[@code='a' or @code='c' or @code='d']"> â </xsl:if> >- <xsl:value-of select="marc:subfield[@code='e']"/> >- </xsl:if> >- <xsl:if test="marc:subfield[@code='g']"> >- <xsl:if test="marc:subfield[@code='e']"> : </xsl:if> >- <xsl:value-of select="marc:subfield[@code='g']"/> >- </xsl:if> >- <xsl:if test="marc:subfield[@code='h']"> >- <xsl:if test="marc:subfield[@code='e' or @code='g']">, </xsl:if> >- <xsl:value-of select="marc:subfield[@code='h']"/> >- </xsl:if> >+ <xsl:for-each select="marc:subfield"> >+ <xsl:choose> >+ <xsl:when test="@code='c' or @code='g'"> >+ <xsl:if test="position()>1"> >+ <xsl:text> : </xsl:text> >+ </xsl:if> >+ <xsl:value-of select="."/> >+ </xsl:when> >+ <xsl:otherwise> >+ <xsl:if test="position()>1"> >+ <xsl:text>, </xsl:text> >+ </xsl:if> >+ <xsl:value-of select="."/> >+ </xsl:otherwise> >+ </xsl:choose> >+ </xsl:for-each> > <xsl:if test="not (position() = last())"> > <xsl:text> ⢠</xsl:text> > </xsl:if> >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21644
:
81066
|
82629
| 82633