Bugzilla – Attachment 82647 Details for
Bug 21869
Bad update statement loses values for MarkLostItemsAsReturned
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21869: Fix incorrect value setting in DB update
Bug-21869-Fix-incorrect-value-setting-in-DB-update.patch (text/plain), 1.71 KB, created by
Marcel de Rooy
on 2018-11-26 13:59:23 UTC
(
hide
)
Description:
Bug 21869: Fix incorrect value setting in DB update
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2018-11-26 13:59:23 UTC
Size:
1.71 KB
patch
obsolete
>From 4a213c38242754228b550e17a292990f0cf9a1ce Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Mon, 26 Nov 2018 13:08:05 +0000 >Subject: [PATCH] Bug 21869: Fix incorrect value setting in DB update >Content-Type: text/plain; charset=utf-8 > >To test: >1 - Set some value for MarkLostAsReturned syspref >2 - Set your db version to 17.12.00.035 (or load an older db) >3 - updatedatabase >4 - Note your values are lost and db is incorrectly set >5 - Apply patch >6 - Reset values >7 - Reset DB version >8 - Run updatedatabase >9 - Original values are retained > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > installer/data/mysql/updatedatabase.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl >index a97b92a..779f70d 100755 >--- a/installer/data/mysql/updatedatabase.pl >+++ b/installer/data/mysql/updatedatabase.pl >@@ -15923,7 +15923,7 @@ if( CheckVersion( $DBversion ) ) { > INSERT IGNORE INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `type` ) VALUES ('UpdateItemWhenLostFromHoldList','',NULL,'This is a list of values to update an item when it is marked as lost from the holds to pull screen','Free'); > } ); > $dbh->do( q{ >- UPDATE systempreferences SET options="batchmod|moredetail|cronjob|additem|pendingreserves", value="batchmod|moredetail|cronjob|additem|pendingreserves" WHERE variable="MarkLostItemsAsReturned"; >+ UPDATE systempreferences SET options="batchmod|moredetail|cronjob|additem|pendingreserves" WHERE variable="MarkLostItemsAsReturned"; > } ); > > SetVersion( $DBversion ); >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21869
:
82640
| 82647