From 8b98b236d653dafa1108309b643380f7a6270450 Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Wed, 28 Nov 2018 13:41:53 -0500 Subject: [PATCH] Bug 21905: Plugin hook intranet_catalog_biblio_enhancements_toolbar_button incorrectly filtered The new plugin hook intranet_catalog_biblio_enhancements_toolbar_button is rendered useless due to the outputted html being escaped using the html filter. It should be using the raw filter instead. Test Plan: 1) Enable plugins 2) Download and install the latest version of the Kitchen Sink plugin https://github.com/bywatersolutions/koha-plugin-kitchen-sink/releases/download/v2.1.21/koha-plugin-kitchen-sink-v2.1.21.kpz 3) Browse to catalogue/detail.pl for a record 4) Note you see the raw html of the plugin output in the toolbar 5) Apply this patch 6) Restart all the things 7) Reload the page 8) Note the html is now correctly rendered as a button --- koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc index e904dde161..b45984ccbe 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc @@ -140,7 +140,7 @@ CAN_user_serials_create_subscription ) %] [% END %] [% FOREACH p IN plugins %] - [% p.intranet_catalog_biblio_enhancements_toolbar_button | html %] + [% p.intranet_catalog_biblio_enhancements_toolbar_button | $raw %] [% END %] -- 2.17.2 (Apple Git-113)