From 1aa77c48c272a97d5a047f9ab9a386180cb78f0e Mon Sep 17 00:00:00 2001 From: Pasi Kallinen Date: Wed, 31 Oct 2018 14:04:33 +0200 Subject: [PATCH] Bug 21736: Allow translating the localization widget messages Content-Type: text/plain; charset=utf-8 The widget used to translate the item type names to other languages has few javascript messages that cannot be translated. Add the mechanism to enable their translation. Test plan: 1) Install and update a language 2) Check the po-files, there's no msgid for "A translation already exists for this language." 3) Apply the patch 4) Install and update a language 5) There should be a msgid for the one in 2, and couple other messages from localization.tt 6) Translate those messages, update the translated templates 7) Go to Administration -> Item types -> Modify item type -> Translate into other languages Add a new translation, check that the message given by the widget was in correct language. Signed-off-by: Pasi Kallinen Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy --- .../intranet-tmpl/prog/en/modules/admin/localization.tt | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/localization.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/localization.tt index 1eb74f9..b60756d 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/localization.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/localization.tt @@ -64,29 +64,29 @@ var message; if ( type == 'success_on_update' ) { message = $('
'); - message.text("Entity %s (code %s) for lang %s has correctly been updated with '%s'".format(data.entity, data.code, data.lang, data.translation)); + message.text(_("Entity %s (code %s) for lang %s has correctly been updated with '%s'").format(data.entity, data.code, data.lang, data.translation)); } else if ( type == 'error_on_update' ) { message = $('
'); if ( data.error_code == 'already_exists' ) { - message.text("A translation already exists for this language."); + message.text(_("A translation already exists for this language.")); } else { - message.text("An error occurred when updating this translation."); + message.text(_("An error occurred when updating this translation.")); } } else if ( type == 'success_on_delete' ) { message = $('
'); - message.text("The translation (id %s) has been removed successfully".format(data.id)); + message.text(_("The translation (id %s) has been removed successfully").format(data.id)); } else if ( type == 'error_on_delete' ) { message = $('
'); - message.text("An error occurred when deleting this translation"); + message.text(_("An error occurred when deleting this translation")); } else if ( type == 'success_on_insert' ) { message = $('
'); - message.text("Translation (id %s) has been added successfully".format(data.id)); + message.text(_("Translation (id %s) has been added successfully").format(data.id)); } else if ( type == 'error_on_insert' ) { message = $('
'); if ( data.error_code == 'already_exists' ) { - message.text("A translation already exists for this language."); + message.text(_("A translation already exists for this language.")); } else { - message.text("An error occurred when adding this translation"); + message.text(_("An error occurred when adding this translation")); } } -- 2.1.4