From 07da6cdf7dba625efa1882ed0be4028175696e90 Mon Sep 17 00:00:00 2001 From: Christopher Brannon Date: Wed, 5 Dec 2018 00:05:47 +0000 Subject: [PATCH] Bug 21944: Test for Circulation.pm --- t/db_dependent/Circulation.t | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t index 93f62571c6..e2ae551166 100755 --- a/t/db_dependent/Circulation.t +++ b/t/db_dependent/Circulation.t @@ -40,6 +40,7 @@ use Koha::Patrons; use Koha::Subscriptions; use Koha::Account::Lines; use Koha::Account::Offsets; +use Koha::Items; my $schema = Koha::Database->schema; $schema->storage->txn_begin; @@ -2365,7 +2366,7 @@ subtest '_FixOverduesOnReturn' => sub { }; subtest 'Set waiting flag' => sub { - plan tests => 4; + plan tests => 8; my $library_1 = $builder->build( { source => 'Branch' } ); my $patron_1 = $builder->build( { source => 'Borrower', value => { branchcode => $library_1->{branchcode}, categorycode => $patron_category->{categorycode} } } ); @@ -2413,6 +2414,17 @@ subtest 'Set waiting flag' => sub { is( $hold->found, 'W', 'Hold is waiting' ); ( $status ) = CheckReserves($item->{itemnumber}); is( $status, 'Waiting', 'Now the hold is waiting'); + + #Bug 21944 - Waiting transfer checked in at branch other than pickup location + + $do_transfer = 1; + AddReturn( $item->{barcode}, $library_1->{branchcode} ); + ModReserveAffect( $item->{itemnumber}, undef, $do_transfer, $reserve_id ); + $hold = Koha::Holds->find( $reserve_id ); + is( $hold->found, 'T', 'Hold is in transit' ); + is( $hold->branchcode, $library_2->{branchcode}, 'Item destination matches the pickup branch'); + ( $status ) = CheckReserves($item->{itemnumber}); + is( $status, 'Reserved', 'Now the hold is set back to reserved'); }; subtest 'CanBookBeIssued | is_overdue' => sub { -- 2.11.0