Bugzilla – Attachment 82876 Details for
Bug 21778
Sorting is inconsistent on patron search based on permissions
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21778: Sort user list by surname,firstname unless user cannot manage patron lists OR edit patrons
Bug-21778-Sort-user-list-by-surnamefirstname-unles.patch (text/plain), 1.69 KB, created by
Josef Moravec
on 2018-12-05 16:21:35 UTC
(
hide
)
Description:
Bug 21778: Sort user list by surname,firstname unless user cannot manage patron lists OR edit patrons
Filename:
MIME Type:
Creator:
Josef Moravec
Created:
2018-12-05 16:21:35 UTC
Size:
1.69 KB
patch
obsolete
>From 5d89f2c5b070045728f9bc475670ed9813aaa1e3 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Wed, 7 Nov 2018 01:32:26 +0000 >Subject: [PATCH] Bug 21778: Sort user list by surname,firstname unless user > cannot manage patron lists OR edit patrons > >To test: >1 - Create four users: > 1 superlibrarian (or with both edit patrons and manage patron > lists) > 1 with only edit patrons and catalogue > 1 with only add to list and catalogue > 1 with catalogue but neither edit patrons or manage patron lists >2 - Search patrons signed in as each user >3 - Note different sorting >4 - Apply patch >5 - Try searching with each patron >6 - Results should always be sorted by surname, firstname >7 - Only in the case of neither extra permission should the checkboxes >be absent > >Signed-off-by: Devinim <kohadevinim@devinim.com.tr> > >Signed-off-by: Josef Moravec <josef.moravec@gmail.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt >index e42b76e9aa..7ca2d2e88e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt >@@ -484,7 +484,7 @@ > }, > 'bFilter': false, > 'bAutoWidth': false, >- [% IF CAN_user_tools_manage_patron_lists %] >+ [% IF CAN_user_borrowers_edit_borrowers || CAN_user_tools_manage_patron_lists %] > 'aaSorting': [[2, 'asc']], > [% ELSE %] > 'aaSorting': [[1, 'asc']], >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21778
:
82015
|
82768
| 82876