From 8164c943f21d847ab9793ad20a92479389a35fa4 Mon Sep 17 00:00:00 2001 From: Katrin Fischer Date: Thu, 6 Dec 2018 12:42:12 +0100 Subject: [PATCH] Bug 21961: Fix typo in manage_didyoumean permission The typo in the installer files will cause problems on new installations as the code for the permission is wrong. This means that on new installations the Did you mean? section on the administration page won't show up. In order to fix this, we need to correct the code in permissions, but also the permissions for users who this permission has been given to. To test: - Start without the patch - Use a new installation with the permission typo - Log in as superlibrarian - Verify that the "did you mean?" configuration page is not visible - Create another staff user with permission to access staff and manage_didyoumean checked - Verify configuration page remains invisible - Apply patch and run database update - Check both users again, the config page should now sohw --- .../data/mysql/atomicupdate/bug_21961_didyouean_typo.sql | 4 ++++ installer/data/mysql/userpermissions.sql | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) create mode 100644 installer/data/mysql/atomicupdate/bug_21961_didyouean_typo.sql diff --git a/installer/data/mysql/atomicupdate/bug_21961_didyouean_typo.sql b/installer/data/mysql/atomicupdate/bug_21961_didyouean_typo.sql new file mode 100644 index 0000000000..a78f85650a --- /dev/null +++ b/installer/data/mysql/atomicupdate/bug_21961_didyouean_typo.sql @@ -0,0 +1,4 @@ +UPDATE permissions SET code = "manage_didyoumean" WHERE code = "manage_didyouean"; +UPDATE user_permissions SET code = "manage_didyoumean" WHERE code = "manage_didyouean"; + +-- Bug 21961 - Fix typo in manage_didyoumean permission diff --git a/installer/data/mysql/userpermissions.sql b/installer/data/mysql/userpermissions.sql index cb71d77b4d..ba1061e91c 100644 --- a/installer/data/mysql/userpermissions.sql +++ b/installer/data/mysql/userpermissions.sql @@ -25,7 +25,7 @@ INSERT INTO permissions (module_bit, code, description) VALUES ( 3, 'manage_item_search_fields', 'Manage item search fields'), ( 3, 'manage_search_engine_config', 'Manage search engine configuration'), ( 3, 'manage_search_targets', 'Manage Z39.50 and SRU server configuration'), - ( 3, 'manage_didyouean', 'Manage Did you mean? configuration'), + ( 3, 'manage_didyoumean', 'Manage Did you mean? configuration'), ( 3, 'manage_column_config', 'Manage column configuration'), ( 3, 'manage_sms_providers', 'Manage SMS cellular providers'), ( 3, 'manage_audio_alerts', 'Manage audio alerts'), -- 2.17.1