Bugzilla – Attachment 82958 Details for
Bug 21608
Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21608: Add value for 'rank-request' when dropdwn disabled
Bug-21608-Add-value-for-rank-request-when-dropdwn-.patch (text/plain), 1.56 KB, created by
Marcel de Rooy
on 2018-12-07 10:12:18 UTC
(
hide
)
Description:
Bug 21608: Add value for 'rank-request' when dropdwn disabled
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2018-12-07 10:12:18 UTC
Size:
1.56 KB
patch
obsolete
>From f5b68138476259b845a19090001b3fb9a274cfb1 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Mon, 26 Nov 2018 18:19:03 +0000 >Subject: [PATCH] Bug 21608: Add value for 'rank-request' when dropdwn disabled >Content-Type: text/plain; charset=utf-8 > >When a field is disabled no value is submitted in the form - this was >causing found holds to be reverted > >To test: >1 - Apply all patches except this one >2 - PLace several holds on one bib >3 - Set at least one waiting or intransit >4 - Making no adjustments hit "Update holds" >5 - Waiting/intransit holds are all reset >6 - Mark them waiting/intransit again >7 - Apply this patch >8 - Click 'update holds' >9 - Found status is not accidentally reverted > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc >index 460fd27..50cb144 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc >@@ -29,6 +29,7 @@ > [% IF Koha.Preference('HoldsSplitQueue') == "nothing" && !hold.found %] > <select name="rank-request"> > [% ELSE %] >+ <input type="hidden" name="rank-request" value="[% hold.priority | html %]"> > <select name="rank-request" disabled="disabled"> > [% END %] > [% IF ( hold.found ) %] >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21608
:
80933
|
81131
|
81134
|
81272
|
81835
|
82157
|
82322
|
82652
|
82956
|
82957
| 82958 |
82959
|
83541