Bugzilla – Attachment 8296 Details for
Bug 7738
"Display more constraints" in subfield configuraton is not properly translatable
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 7738: "Display more constraints' in subfield configuraiton is not properly translatable
Bug-7738-Display-more-constraints-in-subfield-conf.patch (text/plain), 2.59 KB, created by
Katrin Fischer
on 2012-03-19 15:09:41 UTC
(
hide
)
Description:
Bug 7738: "Display more constraints' in subfield configuraiton is not properly translatable
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2012-03-19 15:09:41 UTC
Size:
2.59 KB
patch
obsolete
>From de2a9be22310fd554e4a44f5063ea416ae5815af Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <Katrin.Fischer.83@web.de> >Date: Mon, 19 Mar 2012 16:05:55 +0100 >Subject: [PATCH] Bug 7738: "Display more constraints' in subfield > configuraiton is not properly translatable > >The Javascript toggling the link description was checking for the english >link text. This would not work for translated templates. > >To test: >- Use translated non english templates (de-DE, fr-Fr...) >- Go to: Administration > Bibliographic MARC frameworks >- Select any framework's MARC structure >- Choose any field and edit the subfields >- Check toggling the 'more constraints' for subfields works correctly > and the link description changes accordingly. >--- > .../en/modules/admin/marc_subfields_structure.tt | 26 ++++++++++--------- > 1 files changed, 14 insertions(+), 12 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt >index c196300..a5357d8 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt >@@ -5,17 +5,19 @@ > <script type="text/javascript"> > //<![CDATA[ > >- $(document).ready(function() { >- $('#subfieldtabs > ul').tabs(); >- $("a.displaymore").click(function(){ >- $("#"+$(this).attr("href").replace("#","")).toggle(); >- if($(this).html() == "display more constraints"){ >- $(this).html("hide constraints"); >- } else { >- $(this).html("display more constraints"); >- } >- }); >- }); >+$(document).ready(function() { >+ $('#subfieldtabs > ul').tabs(); >+ $("a.displaymore").click(function(){ >+ var link = $(this); >+ var constraints = $("#"+$(this).attr("href").replace("#","")); >+ constraints.toggle(); >+ if($(constraints).is(':visible')){ >+ link.html(_("Hide constraints")); >+ } else { >+ link.html(_("Display more constraints")); >+ } >+ }); >+}); > > /*function displayMoreConstraint(numlayer){ > var thisdiv = document.getElementById(numlayer); >@@ -102,7 +104,7 @@ > </ol> > </fieldset> > >- <a class="displaymore" href="#more[% loo.urisubfieldcode %]">display more constraints</a> >+ <a class="displaymore" href="#more[% loo.urisubfieldcode %]">Display more constraints</a> > <div id="more[% loo.urisubfieldcode %]" style="display:none; clear: both"> > <fieldset class="rows" style="float:none;"> > <legend>Advanced constraints:</legend> >-- >1.7.5.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7738
:
8296
|
8435