Bugzilla – Attachment 82997 Details for
Bug 20959
Style checkin form more like the checkout form, with collapsed settings panel
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20959: (follow-up) Keep informational notes open after checkin
Bug-20959-follow-up-Keep-informational-notes-open-.patch (text/plain), 3.90 KB, created by
Owen Leonard
on 2018-12-07 19:20:41 UTC
(
hide
)
Description:
Bug 20959: (follow-up) Keep informational notes open after checkin
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2018-12-07 19:20:41 UTC
Size:
3.90 KB
patch
obsolete
>From e5ea16186b124897c615dad43333f37770e02f89 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Fri, 7 Dec 2018 19:10:36 +0000 >Subject: [PATCH] Bug 20959: (follow-up) Keep informational notes open after > checkin > >This patch modifies the template so that the on-screen messages >about settings like 'Book drop mode' stay open from one checkout to >another. > >To test, apply the patch and test checking combinations of 'Forgive >overdue charges' and 'Book drop mode,' verifying that their >corresponding onscreen messages appear correctly and stay visible >(or not) from one checkout to another. > >Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> >--- > .../intranet-tmpl/prog/en/modules/circ/returns.tt | 28 ++++++++++++++++------ > 1 file changed, 21 insertions(+), 7 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >index c013ca2..8b93dad 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >@@ -612,9 +612,9 @@ > [% END %] > <button type="submit" class="btn btn-default">Check in</button> > [% FOREACH inputloo IN inputloop %] >- <input type="hidden" name="ri-[% inputloo.counter %]" value="[% inputloo.barcode %]" /> >- <input type="hidden" name="dd-[% inputloo.counter %]" value="[% inputloo.duedate %]" /> >- <input type="hidden" name="bn-[% inputloo.counter %]" value="[% inputloo.borrowernumber %]" /> >+ <input type="hidden" name="ri-[% inputloo.counter | html %]" value="[% inputloo.barcode | html %]" /> >+ <input type="hidden" name="dd-[% inputloo.counter | html %]" value="[% inputloo.duedate | html %]" /> >+ <input type="hidden" name="bn-[% inputloo.counter | html %]" value="[% inputloo.borrowernumber | html %]" /> > [% END %] > </div> > <div id="show-circ-settings"> >@@ -622,14 +622,28 @@ > </div> > </div> > <div class="col-sm-6"> >- <div id="exemptfines" class="checkin-active-setting" style="display:none;"> >+ [% IF ( exemptfine ) %] >+ <div id="exemptfines" class="checkin-active-setting"> >+ [% ELSE %] >+ <div id="exemptfines" class="checkin-active-setting" style="display:none;"> >+ [% END %] > <p><i class="fa fa-check"></i> Fines for returned items are forgiven.</p> > </div> >- <div id="forgivemanualholdsexpire-alert" class="checkin-active-setting" style="display:none;"> >+ >+ [% IF ( forgivemanualholdsexpire ) %] >+ <div id="forgivemanualholdsexpire-alert" class="checkin-active-setting"> >+ [% ELSE %] >+ <div id="forgivemanualholdsexpire-alert" class="checkin-active-setting" style="display:none;"> >+ [% END %] > <p><i class="fa fa-check"></i> Fines are not charged for manually cancelled holds.</p> > </div> >- <div id="dropboxmode" class="checkin-active-setting" style="display:none;"> >- <p><i class="fa fa-check"></i> Book drop mode. (Effective checkin date is [% dropboxdate %] ).</p> >+ >+ [% IF ( dropboxmode ) %] >+ <div id="dropboxmode" class="checkin-active-setting"> >+ [% ELSE %] >+ <div id="dropboxmode" class="checkin-active-setting" style="display:none;"> >+ [% END %] >+ <p><i class="fa fa-check"></i> Book drop mode. (Effective checkin date is [% dropboxdate | html %] ).</p> > </div> > </div> > </div> >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20959
:
76136
|
76137
|
76139
|
76526
|
76560
|
76561
|
78733
|
78734
|
78810
|
78812
|
78831
|
78839
|
78840
|
78841
|
79757
|
82995
|
82996
|
82997
|
83180
|
83772
|
86477
|
86729
|
87422
|
87933
|
87934
|
91081
|
91123
|
91164