Bugzilla – Attachment 83154 Details for
Bug 21798
We need t::lib::TestBuilder::build_sample_biblio
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21798: replace gimme_a_biblio with build_sample_biblio
Bug-21798-replace-gimmeabiblio-with-buildsamplebib.patch (text/plain), 21.07 KB, created by
Jonathan Druart
on 2018-12-13 12:43:14 UTC
(
hide
)
Description:
Bug 21798: replace gimme_a_biblio with build_sample_biblio
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2018-12-13 12:43:14 UTC
Size:
21.07 KB
patch
obsolete
>From 715a94955c714f88e8cb92c2a1c802f15a58ba0f Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 12 Dec 2018 13:17:02 -0300 >Subject: [PATCH] Bug 21798: replace gimme_a_biblio with build_sample_biblio > >--- > t/db_dependent/Circulation.t | 18 +++++++++--------- > t/db_dependent/Holds.t | 22 +++++++++++----------- > t/db_dependent/Holds/LocalHoldsPriority.t | 2 +- > t/db_dependent/Holds/RevertWaitingStatus.t | 2 +- > t/db_dependent/Items.t | 18 +++++++++--------- > t/db_dependent/Items/DelItem.t | 2 +- > t/db_dependent/Items/GetItemsForInventory.t | 4 ++-- > t/db_dependent/Koha/BiblioUtils/Iterator.t | 2 +- > t/db_dependent/Koha/Biblios.t | 2 +- > t/db_dependent/Labels/t_Label.t | 2 +- > t/db_dependent/OAI/Sets.t | 8 ++++---- > t/db_dependent/Reserves.t | 4 ++-- > t/db_dependent/Serials.t | 2 +- > t/lib/TestBuilder.pm | 2 +- > 14 files changed, 45 insertions(+), 45 deletions(-) > >diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t >index 8b36ed73f2..4992e24e13 100755 >--- a/t/db_dependent/Circulation.t >+++ b/t/db_dependent/Circulation.t >@@ -228,7 +228,7 @@ C4::Context->dbh->do("DELETE FROM accountlines"); > # CanBookBeRenewed tests > C4::Context->set_preference('ItemsDeniedRenewal',''); > # Generate test biblio >- my $biblio = $builder->gimme_a_biblio(); >+ my $biblio = $builder->build_sample_biblio(); > > my $barcode = 'R00000342'; > my $branch = $library2->{branchcode}; >@@ -922,7 +922,7 @@ C4::Context->dbh->do("DELETE FROM accountlines"); > my $branch = $library2->{branchcode}; > > #Create another record >- my $biblio2 = $builder->gimme_a_biblio(); >+ my $biblio2 = $builder->build_sample_biblio(); > > #Create third item > AddItem( >@@ -1001,7 +1001,7 @@ C4::Context->dbh->do("DELETE FROM accountlines"); > my $barcode = '1234567890'; > my $branch = $library2->{branchcode}; > >- my $biblio = $builder->gimme_a_biblio(); >+ my $biblio = $builder->build_sample_biblio(); > > #Create third item > my ( undef, undef, $itemnumber ) = AddItem( >@@ -1058,7 +1058,7 @@ C4::Context->dbh->do("DELETE FROM accountlines"); > undef, 0, > .10, 1 > ); >- my $biblio = $builder->gimme_a_biblio(); >+ my $biblio = $builder->build_sample_biblio(); > > my $barcode1 = '1234'; > my ( undef, undef, $itemnumber1 ) = AddItem( >@@ -1141,7 +1141,7 @@ C4::Context->dbh->do("DELETE FROM accountlines"); > my $branch = $library->{branchcode}; > > #Create another record >- my $biblio = $builder->gimme_a_biblio(); >+ my $biblio = $builder->build_sample_biblio(); > > my (undef, undef, $itemnumber) = AddItem( > { >@@ -1171,7 +1171,7 @@ C4::Context->dbh->do("DELETE FROM accountlines"); > { > my $library = $builder->build({ source => 'Branch' }); > >- my $biblio = $builder->gimme_a_biblio(); >+ my $biblio = $builder->build_sample_biblio(); > > my $barcode = 'just a barcode'; > my ( undef, undef, $itemnumber ) = AddItem( >@@ -1471,7 +1471,7 @@ subtest 'CanBookBeIssued + Statistic patrons "X"' => sub { > subtest 'MultipleReserves' => sub { > plan tests => 3; > >- my $biblio = $builder->gimme_a_biblio(); >+ my $biblio = $builder->build_sample_biblio(); > > my $branch = $library2->{branchcode}; > >@@ -2008,7 +2008,7 @@ subtest '_FixAccountForLostAndReturned' => sub { > ); > my $library = $builder->build_object( { class => 'Koha::Libraries' } ); > >- my $biblio = $builder->gimme_a_biblio({ author => 'Hall, Daria' }); >+ my $biblio = $builder->build_sample_biblio({ author => 'Hall, Daria' }); > > subtest 'Full write-off tests' => sub { > >@@ -2296,7 +2296,7 @@ subtest '_FixAccountForLostAndReturned' => sub { > subtest '_FixOverduesOnReturn' => sub { > plan tests => 10; > >- my $biblio = $builder->gimme_a_biblio({ author => 'Hall, Kylie' }); >+ my $biblio = $builder->build_sample_biblio({ author => 'Hall, Kylie' }); > > my $barcode = 'KD987654321'; > my $branchcode = $library2->{branchcode}; >diff --git a/t/db_dependent/Holds.t b/t/db_dependent/Holds.t >index 99ed954786..16136bf0ac 100755 >--- a/t/db_dependent/Holds.t >+++ b/t/db_dependent/Holds.t >@@ -52,7 +52,7 @@ $insert_sth->execute('DUMMY'); > $insert_sth->execute('ONLY1'); > > # Setup Test------------------------ >-my $biblio = $builder->gimme_a_biblio({ itemtype => 'DUMMY' }); >+my $biblio = $builder->build_sample_biblio({ itemtype => 'DUMMY' }); > > # Create item instance for testing. > my ($item_bibnum, $item_bibitemnum, $itemnumber) >@@ -237,7 +237,7 @@ is( $hold->priority, '6', "Test AlterPriority(), move to bottom" ); > # Note that canreservefromotherbranches has no effect if > # IndependentBranches is OFF. > >-my $foreign_biblio = $builder->gimme_a_biblio({ itemtype => 'DUMMY' }); >+my $foreign_biblio = $builder->build_sample_biblio({ itemtype => 'DUMMY' }); > my ($foreign_item_bibnum, $foreign_item_bibitemnum, $foreign_itemnumber) > = AddItem({ homebranch => $branch_2, holdingbranch => $branch_2 } , $foreign_biblio->biblionumber); > $dbh->do('DELETE FROM issuingrules'); >@@ -282,7 +282,7 @@ ok( > > { > # Regression test for bug 11336 # Test if ModReserve correctly recalculate the priorities >- $biblio = $builder->gimme_a_biblio({ itemtype => 'DUMMY' }); >+ $biblio = $builder->build_sample_biblio({ itemtype => 'DUMMY' }); > ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem({ homebranch => $branch_1, holdingbranch => $branch_1 } , $biblio->biblionumber); > my $reserveid1 = AddReserve($branch_1, $borrowernumbers[0], $biblio->biblionumber, '', 1); > ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem({ homebranch => $branch_1, holdingbranch => $branch_1 } , $biblio->biblionumber); >@@ -319,7 +319,7 @@ ok( CanItemBeReserved( $borrowernumbers[0], $itemnumber)->{status} eq 'damaged', > ok( !defined( ( CheckReserves($itemnumber) )[1] ), "Hold cannot be trapped for damaged item with AllowHoldsOnDamagedItems disabled" ); > > # Regression test for bug 9532 >-$biblio = $builder->gimme_a_biblio({ itemtype => 'CANNOT' }); >+$biblio = $builder->build_sample_biblio({ itemtype => 'CANNOT' }); > ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem({ homebranch => $branch_1, holdingbranch => $branch_1, itype => 'CANNOT' } , $biblio->biblionumber); > AddReserve( > $branch_1, >@@ -367,7 +367,7 @@ $dbh->do(q{ > INSERT INTO branch_item_rules (branchcode, itemtype, holdallowed, returnbranch) > VALUES (?, ?, ?, ?) > }, {}, $branch_1, 'CAN', 1, 'homebranch'); >-$biblio = $builder->gimme_a_biblio({ itemtype => 'CANNOT' }); >+$biblio = $builder->build_sample_biblio({ itemtype => 'CANNOT' }); > ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem( > { homebranch => $branch_1, holdingbranch => $branch_1, itype => 'CANNOT' } , $biblio->biblionumber); > is(CanItemBeReserved($borrowernumbers[0], $itemnumber)->{status}, 'notReservable', >@@ -393,7 +393,7 @@ $dbh->do('DELETE FROM issues'); > $dbh->do('DELETE FROM items'); > $dbh->do('DELETE FROM biblio'); > >-$biblio = $builder->gimme_a_biblio({ itemtype => 'ONLY1' }); >+$biblio = $builder->build_sample_biblio({ itemtype => 'ONLY1' }); > ( $item_bibnum, $item_bibitemnum, $itemnumber ) > = AddItem( { homebranch => $branch_1, holdingbranch => $branch_1 }, $biblio->biblionumber ); > >@@ -418,7 +418,7 @@ subtest 'Test max_holds per library/patron category' => sub { > $dbh->do('DELETE FROM issuingrules'); > $dbh->do('DELETE FROM circulation_rules'); > >- $biblio = $builder->gimme_a_biblio({ itemtype => 'TEST' }); >+ $biblio = $builder->build_sample_biblio({ itemtype => 'TEST' }); > ( $item_bibnum, $item_bibitemnum, $itemnumber ) = > AddItem( { homebranch => $branch_1, holdingbranch => $branch_1 }, > $biblio->biblionumber ); >@@ -488,7 +488,7 @@ subtest 'Test max_holds per library/patron category' => sub { > subtest 'Pickup location availability tests' => sub { > plan tests => 3; > >- $biblio = $builder->gimme_a_biblio({ itemtype => 'ONLY1' }); >+ $biblio = $builder->build_sample_biblio({ itemtype => 'ONLY1' }); > my ( $item_bibnum, $item_bibitemnum, $itemnumber ) > = AddItem( { homebranch => $branch_1, holdingbranch => $branch_1 }, $biblio->biblionumber ); > #Add a default rule to allow some holds >@@ -533,21 +533,21 @@ subtest 'CanItemBeReserved / holds_per_day tests' => sub { > my $patron = $builder->build_object( { class => 'Koha::Patrons' } ); > > # Create 3 biblios with items >- my $biblio_1 = $builder->gimme_a_biblio({ itemtype => $itemtype->itemtype }); >+ my $biblio_1 = $builder->build_sample_biblio({ itemtype => $itemtype->itemtype }); > my ( undef, undef, $itemnumber_1 ) = AddItem( > { homebranch => $library->branchcode, > holdingbranch => $library->branchcode > }, > $biblio_1->biblionumber > ); >- my $biblio_2 = $builder->gimme_a_biblio({ itemtype => $itemtype->itemtype }); >+ my $biblio_2 = $builder->build_sample_biblio({ itemtype => $itemtype->itemtype }); > my ( undef, undef, $itemnumber_2 ) = AddItem( > { homebranch => $library->branchcode, > holdingbranch => $library->branchcode > }, > $biblio_2->biblionumber > ); >- my $biblio_3 = $builder->gimme_a_biblio({ itemtype => $itemtype->itemtype }); >+ my $biblio_3 = $builder->build_sample_biblio({ itemtype => $itemtype->itemtype }); > my ( undef, undef, $itemnumber_3 ) = AddItem( > { homebranch => $library->branchcode, > holdingbranch => $library->branchcode >diff --git a/t/db_dependent/Holds/LocalHoldsPriority.t b/t/db_dependent/Holds/LocalHoldsPriority.t >index 5e087161b5..0ecb9d124c 100755 >--- a/t/db_dependent/Holds/LocalHoldsPriority.t >+++ b/t/db_dependent/Holds/LocalHoldsPriority.t >@@ -40,7 +40,7 @@ my $itemtype = $builder->build( > > my $borrowers_count = 5; > >-my $biblio = $builder->gimme_a_biblio(); >+my $biblio = $builder->build_sample_biblio(); > my ( $item_bibnum, $item_bibitemnum, $itemnumber ) = AddItem( > { homebranch => $library4->{branchcode}, > holdingbranch => $library3->{branchcode}, >diff --git a/t/db_dependent/Holds/RevertWaitingStatus.t b/t/db_dependent/Holds/RevertWaitingStatus.t >index 4ccfbb51d9..facf6c8e96 100755 >--- a/t/db_dependent/Holds/RevertWaitingStatus.t >+++ b/t/db_dependent/Holds/RevertWaitingStatus.t >@@ -52,7 +52,7 @@ sub Mock_userenv { > > my $borrowers_count = 3; > >-my $biblio = $builder->gimme_a_biblio(); >+my $biblio = $builder->build_sample_biblio(); > my $item_barcode = 'my_barcode'; > my ( $item_bibnum, $item_bibitemnum, $itemnumber ) = AddItem( > { homebranch => $branchcode, >diff --git a/t/db_dependent/Items.t b/t/db_dependent/Items.t >index 435b7516ef..5cf8c07e4e 100755 >--- a/t/db_dependent/Items.t >+++ b/t/db_dependent/Items.t >@@ -56,7 +56,7 @@ subtest 'General Add, Get and Del tests' => sub { > > # Create a biblio instance for testing > t::lib::Mocks::mock_preference('marcflavour', 'MARC21'); >- my $biblio = $builder->gimme_a_biblio(); >+ my $biblio = $builder->build_sample_biblio(); > > # Add an item. > my ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem({ homebranch => $library->{branchcode}, holdingbranch => $library->{branchcode}, location => $location, itype => $itemtype->{itemtype} } , $biblio->biblionumber); >@@ -168,7 +168,7 @@ subtest 'GetHiddenItemnumbers tests' => sub { > > # Create a new biblio > t::lib::Mocks::mock_preference('marcflavour', 'MARC21'); >- my $biblio = $builder->gimme_a_biblio(); >+ my $biblio = $builder->build_sample_biblio(); > > # Add two items > my ( $item1_bibnum, $item1_bibitemnum, $item1_itemnumber ) = AddItem( >@@ -266,7 +266,7 @@ subtest 'GetItemsInfo tests' => sub { > }); > > # Add a biblio >- my $biblio = $builder->gimme_a_biblio(); >+ my $biblio = $builder->build_sample_biblio(); > # Add an item > my ( $item_bibnum, $item_bibitemnum, $itemnumber ) = AddItem( > { >@@ -357,8 +357,8 @@ subtest 'SearchItems test' => sub { > t::lib::Mocks::mock_preference('marcflavour', 'MARC21'); > my $cpl_items_before = SearchItemsByField( 'homebranch', $library1->{branchcode}); > >- my $biblio = $builder->gimme_a_biblio({ title => 'Silence in the library' }); >- $builder->gimme_a_biblio({ title => 'Silence in the shadow' }); >+ my $biblio = $builder->build_sample_biblio({ title => 'Silence in the library' }); >+ $builder->build_sample_biblio({ title => 'Silence in the shadow' }); > > my (undef, $initial_items_count) = SearchItems(undef, {rows => 1}); > >@@ -535,7 +535,7 @@ subtest 'Koha::Item(s) tests' => sub { > > # Create a biblio and item for testing > t::lib::Mocks::mock_preference('marcflavour', 'MARC21'); >- my $biblio = $builder->gimme_a_biblio(); >+ my $biblio = $builder->build_sample_biblio(); > my ( $item_bibnum, $item_bibitemnum, $itemnumber ) = AddItem( > { > homebranch => $library1->{branchcode}, >@@ -576,7 +576,7 @@ subtest 'C4::Biblio::EmbedItemsInMarcBiblio' => sub { > source => 'Itemtype', > }); > >- my $biblio = $builder->gimme_a_biblio(); >+ my $biblio = $builder->build_sample_biblio(); > my $item_infos = [ > { homebranch => $library1->{branchcode}, holdingbranch => $library1->{branchcode} }, > { homebranch => $library1->{branchcode}, holdingbranch => $library1->{branchcode} }, >@@ -703,7 +703,7 @@ subtest 'C4::Items::_build_default_values_for_mod_marc' => sub { > my $itemtype = $builder->build({ source => 'Itemtype' })->{itemtype}; > > # Create a record with a barcode >- my $biblio = $builder->gimme_a_biblio({ frameworkcode => $framework->{frameworkcode} }); >+ my $biblio = $builder->build_sample_biblio({ frameworkcode => $framework->{frameworkcode} }); > my $item_record = new MARC::Record; > my $a_barcode = 'a barcode'; > my $barcode_field = MARC::Field->new( >@@ -849,7 +849,7 @@ subtest 'Test logging for ModItem' => sub { > > # Create a biblio instance for testing > t::lib::Mocks::mock_preference('marcflavour', 'MARC21'); >- my $biblio = $builder->gimme_a_biblio(); >+ my $biblio = $builder->build_sample_biblio(); > > # Add an item. > my ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem({ homebranch => $library->{branchcode}, holdingbranch => $library->{branchcode}, location => $location, itype => $itemtype->{itemtype} } , $biblio->biblionumber); >diff --git a/t/db_dependent/Items/DelItem.t b/t/db_dependent/Items/DelItem.t >index 4d719a4556..f865fa46ac 100644 >--- a/t/db_dependent/Items/DelItem.t >+++ b/t/db_dependent/Items/DelItem.t >@@ -16,7 +16,7 @@ my $library = $builder->build({ > source => 'Branch', > }); > >-my $biblio = $builder->gimme_a_biblio(); >+my $biblio = $builder->build_sample_biblio(); > > my ( $item_bibnum, $item_bibitemnum, $itemnumber ); > ( $item_bibnum, $item_bibitemnum, $itemnumber ) = >diff --git a/t/db_dependent/Items/GetItemsForInventory.t b/t/db_dependent/Items/GetItemsForInventory.t >index fa7fc9139b..e81ab8ba2d 100755 >--- a/t/db_dependent/Items/GetItemsForInventory.t >+++ b/t/db_dependent/Items/GetItemsForInventory.t >@@ -74,8 +74,8 @@ subtest 'Skip items with waiting holds' => sub { > my $title_1 = 'Title 1, '; > my $title_2 = 'Title 2, bizzarre one so doesn\'t already exist'; > >- my $biblio_1 = $builder->gimme_a_biblio({ itemtype => $itemtype->itemtype, title => $title_1 }); >- my $biblio_2 = $builder->gimme_a_biblio({ itemtype => $itemtype->itemtype, title => $title_2 }); >+ my $biblio_1 = $builder->build_sample_biblio({ itemtype => $itemtype->itemtype, title => $title_1 }); >+ my $biblio_2 = $builder->build_sample_biblio({ itemtype => $itemtype->itemtype, title => $title_2 }); > > my ( $items_1, $first_items_count ) = GetItemsForInventory(); > is( scalar @{$items_1}, $first_items_count, 'Results and count match' ); >diff --git a/t/db_dependent/Koha/BiblioUtils/Iterator.t b/t/db_dependent/Koha/BiblioUtils/Iterator.t >index 26a3c49483..c2c5a39f28 100644 >--- a/t/db_dependent/Koha/BiblioUtils/Iterator.t >+++ b/t/db_dependent/Koha/BiblioUtils/Iterator.t >@@ -47,7 +47,7 @@ my $itemtype = $builder->build({ > > # Create a biblio instance for testing > t::lib::Mocks::mock_preference('marcflavour', 'MARC21'); >-my $biblio = $builder->gimme_a_biblio(); >+my $biblio = $builder->build_sample_biblio(); > > # Add an item. > my ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem({ homebranch => $library->{branchcode}, holdingbranch => $library->{branchcode}, location => $location, itype => $itemtype->{itemtype} } , $biblio->biblionumber); >diff --git a/t/db_dependent/Koha/Biblios.t b/t/db_dependent/Koha/Biblios.t >index 60c5157f25..2ea000d083 100644 >--- a/t/db_dependent/Koha/Biblios.t >+++ b/t/db_dependent/Koha/Biblios.t >@@ -143,7 +143,7 @@ subtest 'can_be_transferred' => sub { > my $library1 = $builder->build_object( { class => 'Koha::Libraries' } ); > my $library2 = $builder->build_object( { class => 'Koha::Libraries' } ); > my $library3 = $builder->build_object( { class => 'Koha::Libraries' } ); >- my $biblio = $builder->gimme_a_biblio({ itemtype => 'ONLY1' }); >+ my $biblio = $builder->build_sample_biblio({ itemtype => 'ONLY1' }); > my ($item_bibnum, $item_bibitemnum, $itemnumber) > = AddItem({ homebranch => $library1->branchcode, holdingbranch => $library1->branchcode }, $biblio->biblionumber); > my $item = Koha::Items->find($itemnumber); >diff --git a/t/db_dependent/Labels/t_Label.t b/t/db_dependent/Labels/t_Label.t >index e61e593967..e8f0ab3476 100644 >--- a/t/db_dependent/Labels/t_Label.t >+++ b/t/db_dependent/Labels/t_Label.t >@@ -58,7 +58,7 @@ my $itemtype = > > C4::Context->set_userenv( undef, undef, undef, undef, undef, undef, $branch_1 ); > >-my $bibnum = $builder->gimme_a_biblio({ frameworkcode => $frameworkcode })->biblionumber; >+my $bibnum = $builder->build_sample_biblio({ frameworkcode => $frameworkcode })->biblionumber; > > # Create a helper item instance for testing > my ( $item_bibnum, $item_bibitemnum, $itemnumber ) = AddItem( >diff --git a/t/db_dependent/OAI/Sets.t b/t/db_dependent/OAI/Sets.t >index ede51dac4c..f68552613f 100644 >--- a/t/db_dependent/OAI/Sets.t >+++ b/t/db_dependent/OAI/Sets.t >@@ -355,10 +355,10 @@ ok (!defined(AddOAISetsBiblios(my $arg=[])), 'AddOAISetsBiblios with a no HASH a > ok (defined(AddOAISetsBiblios($arg={})), 'AddOAISetsBiblios with a HASH argument is def'); > > # Create a biblio instance for testing >-my $biblio_1 = $builder->gimme_a_biblio({ author => 'Moffat, Steven' }); >+my $biblio_1 = $builder->build_sample_biblio({ author => 'Moffat, Steven' }); > my $biblionumber1 = $biblio_1->biblionumber; > isa_ok(\$biblionumber1, 'SCALAR', '$biblionumber1 is a SCALAR'); >-my $biblio_2 = $builder->gimme_a_biblio({ author => 'Moffat, Steven' }); >+my $biblio_2 = $builder->build_sample_biblio({ author => 'Moffat, Steven' }); > my $biblionumber2 = $biblio_2->biblionumber; > isa_ok(\$biblionumber2, 'SCALAR', '$biblionumber2 is a SCALAR'); > >@@ -521,7 +521,7 @@ ModOAISetMappings($setVH_id, $mappingsVH); > > > #Create a biblio notice corresponding at one of mappings >-my $biblio_VH = $builder->gimme_a_biblio({ author => 'Victor Hugo' }); >+my $biblio_VH = $builder->build_sample_biblio({ author => 'Victor Hugo' }); > my $biblionumberVH = $biblio_VH->biblionumber; > > #Update >@@ -577,7 +577,7 @@ ModOAISetMappings($setNotVH_id, $mappingsNotVH); > > > #Create a biblio notice corresponding at one of mappings >-my $biblio_NotVH = $builder->gimme_a_biblio({ author => 'Sponge, Bob' }); >+my $biblio_NotVH = $builder->build_sample_biblio({ author => 'Sponge, Bob' }); > my $biblionumberNotVH = $biblio_NotVH->biblionumber; > > #Update >diff --git a/t/db_dependent/Reserves.t b/t/db_dependent/Reserves.t >index ea335ae212..b8c314c8f0 100755 >--- a/t/db_dependent/Reserves.t >+++ b/t/db_dependent/Reserves.t >@@ -81,7 +81,7 @@ C4::Context->set_userenv( > undef, undef, undef, undef, undef, undef, $branch_1 > ); > >-my $bibnum = $builder->gimme_a_biblio({frameworkcode => $frameworkcode})->biblionumber; >+my $bibnum = $builder->build_sample_biblio({frameworkcode => $frameworkcode})->biblionumber; > > # Create a helper item instance for testing > my ( $item_bibnum, $item_bibitemnum, $itemnumber ) = AddItem( >@@ -214,7 +214,7 @@ $dbh->do( > $branch_2, 10, 2, 'homebranch', > ); > >-my $bibnum2 = $builder->gimme_a_biblio({frameworkcode => $frameworkcode})->biblionumber; >+my $bibnum2 = $builder->build_sample_biblio({frameworkcode => $frameworkcode})->biblionumber; > > my ($itemnum_cpl, $itemnum_fpl); > ( undef, undef, $itemnum_cpl ) = AddItem( >diff --git a/t/db_dependent/Serials.t b/t/db_dependent/Serials.t >index 5d08fb1a17..f34a02587c 100755 >--- a/t/db_dependent/Serials.t >+++ b/t/db_dependent/Serials.t >@@ -145,7 +145,7 @@ subtest 'Values should not be erased on editing' => sub { > > plan tests => 1; > >- my $biblio = $builder->gimme_a_biblio(); >+ my $biblio = $builder->build_sample_biblio(); > my $biblionumber = $biblio->biblionumber; > my ( $icn_tag, $icn_sf ) = GetMarcFromKohaField( 'items.itemcallnumber', '' ); > my ( $it_tag, $it_sf ) = GetMarcFromKohaField( 'items.itype', '' ); >diff --git a/t/lib/TestBuilder.pm b/t/lib/TestBuilder.pm >index d97243765f..c66291cf1f 100644 >--- a/t/lib/TestBuilder.pm >+++ b/t/lib/TestBuilder.pm >@@ -127,7 +127,7 @@ sub build { > }); > } > >-sub gimme_a_biblio { >+sub build_sample_biblio { > my ( $self, $args ) = @_; > > my $title = $args->{title} || 'Some boring read'; >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21798
:
82116
|
82276
|
82277
|
82278
|
82943
|
83136
|
83137
|
83149
|
83150
|
83151
|
83152
|
83153
|
83154
|
83156
|
83157
|
83158
|
83159
|
83160
|
83161
|
83162
|
83163
|
84490
|
84491
|
84492
|
84493
|
84494
|
84495
|
84496