Bugzilla – Attachment 83159 Details for
Bug 21798
We need t::lib::TestBuilder::build_sample_biblio
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21798: Fix a wrong test
Bug-21798-Fix-a-wrong-test.patch (text/plain), 1.18 KB, created by
Marcel de Rooy
on 2018-12-13 13:06:17 UTC
(
hide
)
Description:
Bug 21798: Fix a wrong test
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2018-12-13 13:06:17 UTC
Size:
1.18 KB
patch
obsolete
>From fad4916666d4a0dc5b24514463200eedfb9074af Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 13 Nov 2018 11:22:15 -0300 >Subject: [PATCH] Bug 21798: Fix a wrong test >Content-Type: text/plain; charset=utf-8 > >Now biblioitem.itemtype has a value, GetItem should fill itype with this >value if item-level_itypes it not set > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > t/db_dependent/Items.t | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/t/db_dependent/Items.t b/t/db_dependent/Items.t >index f09b244..9c914b0 100755 >--- a/t/db_dependent/Items.t >+++ b/t/db_dependent/Items.t >@@ -106,7 +106,7 @@ subtest 'General Add, Get and Del tests' => sub { > is( $getitem->{itype}, $itemtype->{itemtype}, "Itemtype set correctly when using item-level_itypes" ); > t::lib::Mocks::mock_preference('item-level_itypes', '0'); > $getitem = GetItem($itemnumber); >- is( $getitem->{itype}, undef, "Itemtype set correctly when not using item-level_itypes" ); >+ is( $getitem->{itype}, $biblio->biblioitem->itemtype, "Itemtype set correctly when not using item-level_itypes" ); > > $schema->storage->txn_rollback; > }; >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21798
:
82116
|
82276
|
82277
|
82278
|
82943
|
83136
|
83137
|
83149
|
83150
|
83151
|
83152
|
83153
|
83154
|
83156
|
83157
|
83158
|
83159
|
83160
|
83161
|
83162
|
83163
|
84490
|
84491
|
84492
|
84493
|
84494
|
84495
|
84496