From b45a88a3eb9d5b4872622cece2aa0646c79923a5 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Thu, 13 Dec 2018 16:26:31 -0300 Subject: [PATCH] Bug 20959: Prevent the scrollbar to move to the top on click We could use e.preventDefault but it seems better to make the link wider than just the size of the text. However we lost the on a:hover style, we may want to reintroduce it --- koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss | 1 + koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt | 3 ++- koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 3 ++- koha-tmpl/intranet-tmpl/prog/js/pages/circulation.js | 2 +- 4 files changed, 6 insertions(+), 3 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss index 7a69dd37b8..e392849cdb 100644 --- a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss +++ b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss @@ -1946,6 +1946,7 @@ i { #show-circ-settings { margin-top: .5em; + cursor: pointer; } .checkin-active-setting { diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt index c8f982e7b5..51f7a10816 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt @@ -528,7 +528,8 @@ No patron matched [% message | html %]
- Checkout settings + + Checkout settings
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt index 8b93dada52..a5cf39e59c 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt @@ -618,7 +618,8 @@ [% END %]
- Checkin settings + + Checkin settings
diff --git a/koha-tmpl/intranet-tmpl/prog/js/pages/circulation.js b/koha-tmpl/intranet-tmpl/prog/js/pages/circulation.js index 8bfd6670d7..32708254e9 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/pages/circulation.js +++ b/koha-tmpl/intranet-tmpl/prog/js/pages/circulation.js @@ -66,7 +66,7 @@ $(document).ready(function() { circ_settings_icon.removeClass("fa-caret-down").addClass("fa-caret-right"); } - $("#show-circ-settings a").on("click",function(){ + $("#show-circ-settings").on("click",function(){ if( circ_settings.is(":hidden")){ circ_settings.show(); circ_settings_icon.removeClass("fa-caret-right").addClass("fa-caret-down"); -- 2.11.0