Bugzilla – Attachment 83180 Details for
Bug 20959
Style checkin form more like the checkout form, with collapsed settings panel
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20959: Prevent the scrollbar to move to the top on click
Bug-20959-Prevent-the-scrollbar-to-move-to-the-top.patch (text/plain), 3.23 KB, created by
Jonathan Druart
on 2018-12-13 19:29:35 UTC
(
hide
)
Description:
Bug 20959: Prevent the scrollbar to move to the top on click
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2018-12-13 19:29:35 UTC
Size:
3.23 KB
patch
obsolete
>From b45a88a3eb9d5b4872622cece2aa0646c79923a5 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 13 Dec 2018 16:26:31 -0300 >Subject: [PATCH] Bug 20959: Prevent the scrollbar to move to the top on click > >We could use e.preventDefault but it seems better to make the link wider >than just the size of the text. > >However we lost the on a:hover style, we may want to reintroduce it >--- > koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss | 1 + > koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt | 3 ++- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 3 ++- > koha-tmpl/intranet-tmpl/prog/js/pages/circulation.js | 2 +- > 4 files changed, 6 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >index 7a69dd37b8..e392849cdb 100644 >--- a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >+++ b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >@@ -1946,6 +1946,7 @@ i { > > #show-circ-settings { > margin-top: .5em; >+ cursor: pointer; > } > > .checkin-active-setting { >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >index c8f982e7b5..51f7a10816 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >@@ -528,7 +528,8 @@ No patron matched <span class="ex">[% message | html %]</span> > <button type="submit" class="btn btn-default">Check out</button> > > <div id="show-circ-settings"> >- <a href="#"><i class="fa fa-caret-right circ-settings-icon"></i> Checkout settings</a> >+ <i class="fa fa-caret-right circ-settings-icon"></i> >+ Checkout settings > </div> > > <div class="circ-settings"> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >index 8b93dada52..a5cf39e59c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >@@ -618,7 +618,8 @@ > [% END %] > </div> > <div id="show-circ-settings"> >- <a href="#"><i class="fa circ-settings-icon fa-caret-down"></i> Checkin settings</a> >+ <i class="fa fa-caret-down circ-settings-icon"></i> >+ Checkin settings > </div> > </div> > <div class="col-sm-6"> >diff --git a/koha-tmpl/intranet-tmpl/prog/js/pages/circulation.js b/koha-tmpl/intranet-tmpl/prog/js/pages/circulation.js >index 8bfd6670d7..32708254e9 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/pages/circulation.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/pages/circulation.js >@@ -66,7 +66,7 @@ $(document).ready(function() { > circ_settings_icon.removeClass("fa-caret-down").addClass("fa-caret-right"); > } > >- $("#show-circ-settings a").on("click",function(){ >+ $("#show-circ-settings").on("click",function(){ > if( circ_settings.is(":hidden")){ > circ_settings.show(); > circ_settings_icon.removeClass("fa-caret-right").addClass("fa-caret-down"); >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20959
:
76136
|
76137
|
76139
|
76526
|
76560
|
76561
|
78733
|
78734
|
78810
|
78812
|
78831
|
78839
|
78840
|
78841
|
79757
|
82995
|
82996
|
82997
|
83180
|
83772
|
86477
|
86729
|
87422
|
87933
|
87934
|
91081
|
91123
|
91164