Bugzilla – Attachment 83310 Details for
Bug 22016
Always send CT field for SIP checkin, even if empty
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22016: Always send CT field for SIP checkin, even if empty
Bug-22016-Always-send-CT-field-for-SIP-checkin-eve.patch (text/plain), 2.47 KB, created by
Kyle M Hall
on 2018-12-17 19:42:56 UTC
(
hide
)
Description:
Bug 22016: Always send CT field for SIP checkin, even if empty
Filename:
MIME Type:
Creator:
Kyle M Hall
Created:
2018-12-17 19:42:56 UTC
Size:
2.47 KB
patch
obsolete
>From ca635181bf555011f7f590a61c75f8f6203a289b Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Mon, 17 Dec 2018 14:41:48 -0500 >Subject: [PATCH] Bug 22016: Always send CT field for SIP checkin, even if > empty > >Some SIP devices ( in this particular case, bin sorting machines from RFID Library Solutions ) require a CT field to be sent, even if that field is empty. Koha should be able to support this behavior. > >Test Plan: >1) Apply this patch >2) Enable the new option ct_always_send for a SIP2 account >3) Restart SIP >4) Check in an item successfully via SIP, which will not be transferred >5) Note the response contains a CT field with no value > >Sponsored-by: Pueblo City-County Library District > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > C4/SIP/Sip/MsgType.pm | 2 +- > etc/SIPconfig.xml | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > >diff --git a/C4/SIP/Sip/MsgType.pm b/C4/SIP/Sip/MsgType.pm >index 6c6056b228..43b7772b70 100644 >--- a/C4/SIP/Sip/MsgType.pm >+++ b/C4/SIP/Sip/MsgType.pm >@@ -677,7 +677,7 @@ sub handle_checkin { > $resp .= maybe_add( FID_COLLECTION_CODE, $item->collection_code ); > } > $resp .= maybe_add( FID_CALL_NUMBER, $item->call_number ); >- $resp .= maybe_add( FID_DESTINATION_LOCATION, $item->destination_loc ); >+ $resp .= add_field( FID_DESTINATION_LOCATION, $item->destination_loc ) if ( $item->destination_loc || $server->{account}->{ct_always_send} ); > $resp .= maybe_add( FID_HOLD_PATRON_ID, $item->hold_patron_bcode ); > $resp .= maybe_add( FID_HOLD_PATRON_NAME, $item->hold_patron_name( $server->{account}->{da_field_template} ) ); > if ( $status->hold and $status->hold->{branchcode} ne $item->destination_loc ) { >diff --git a/etc/SIPconfig.xml b/etc/SIPconfig.xml >index 49ff852698..7a2fd65cc3 100644 >--- a/etc/SIPconfig.xml >+++ b/etc/SIPconfig.xml >@@ -52,6 +52,7 @@ > delimiter="|" error-detect="enabled" institution="LPL" > send_patron_home_library_in_af="1" > cv_send_00_on_success="1" >+ ct_always_send="1" > ae_field_template="[% patron.surname %][% IF patron.firstname %], [% patron.firstname %][% END %]" > da_field_template="[% patron.surname %][% IF patron.firstname %], [% patron.firstname %][% END %]" > av_field_template="[% accountline.description %] [% accountline.amountoutstanding | format('%.2f') %]" > >-- >2.17.2 (Apple Git-113)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22016
:
83310
|
83345
|
85147
|
85290