Bugzilla – Attachment 83329 Details for
Bug 21999
C4::Circulation::AddIssue uses DBIx::Class directly
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21999: FIXMEs are fixed!
Bug-21999-FIXMEs-are-fixed.patch (text/plain), 1.26 KB, created by
Jonathan Druart
on 2018-12-17 21:29:47 UTC
(
hide
)
Description:
Bug 21999: FIXMEs are fixed!
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2018-12-17 21:29:47 UTC
Size:
1.26 KB
patch
obsolete
>From db62923ebd8d39135922238313fca87036d08cad Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 17 Dec 2018 18:21:04 -0300 >Subject: [PATCH] Bug 21999: FIXMEs are fixed! > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > t/db_dependent/Circulation.t | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t >index 42783ea401..e15d9b510b 100755 >--- a/t/db_dependent/Circulation.t >+++ b/t/db_dependent/Circulation.t >@@ -1233,7 +1233,7 @@ subtest 'CanBookBeIssued & AllowReturnToBranch' => sub { > set_userenv($holdingbranch); > > my $issue = AddIssue( $patron_1->unblessed, $item->{barcode} ); >- is( ref($issue), 'Koha::Checkout' ); # FIXME Should be Koha::Checkout >+ is( ref($issue), 'Koha::Checkout', 'AddIssue should return a Koha::Checkout object' ); > > my ( $error, $question, $alerts ); > >@@ -1326,7 +1326,7 @@ subtest 'AddIssue & AllowReturnToBranch' => sub { > > set_userenv($holdingbranch); > >- my $ref_issue = 'Koha::Checkout'; # FIXME Should be Koha::Checkout >+ my $ref_issue = 'Koha::Checkout'; > my $issue = AddIssue( $patron_1, $item->{barcode} ); > > my ( $error, $question, $alerts ); >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21999
:
83215
|
83216
|
83244
|
83245
|
83327
|
83328
| 83329 |
83330