From 253c5bb16be27e8822c29e57036dd0ea9a4f53a8 Mon Sep 17 00:00:00 2001 From: Alex Buckley Date: Sun, 26 Aug 2018 15:16:47 +1200 Subject: [PATCH] Bug 15565: Fixed issues preventing any item-level holds being placed in OPAC This commit fixes two bugs: 1. C4::Reserves->CanItemBeReserved() returns an output in a hash in the format: status => 'output' However opac-reserve.pl is not accessing th output of this function correctly consequently no item is ever reservable. And so after a patron submits the reservation form on opac-reserve.pl it looks like the item-level reservation has successfully been placed however it has not and no error message is displayed to them. This commit stores the output of the aforementioned function in a hash and then checks the value of the status key. As a result opac-reserve.pl now correctly accesses the value returned and item level holds are successfully placed from the OPAC. 2. If a biblio has previously been reserved then the opac-reserve.pl page shows the 'Next available item' and 'A specific item' radio buttons to be disabled to ensure patrons cannot place a reservation of a different type on the biblio. With both of these radio buttons being disabled it results in item level holds placed in the OPAC on a previously reserved item not being stored in the database. This is very confusing for users. I have implemented a conditional which checks what the forced_hold_type of the previous hold was. If it was 'item' then the $reqtype = 'Specific' and if it was 'record' then $reqtype is 'Any'. This means there will always be a value for $reqtype, and this variable is checked if it is equal to 'Specific' and if it is then an item level hold is placed. Test plan: 1. Ensure in your circulation rules that 'Item level holds' is enabled 2. Apply all patches on this bug report except this commit 3. In the OPAC try placing a item level hold (and notice you can submit the opac-reserve.pl page and no error messages are displayed. However the hold(s) are not being placed. 4. Place an item level hold(s) on the biblio from staff client interface and then return to the opac-reserve.pl page for the biblio in the OPAC and notice both the 'Next available' and 'A specific item' radio buttons are disabled. 5. Again try placing an item level hold in the OPAC and notice dispite no error/warning message being displayed the hold is not being placed. 6. Apply this patch 7. Restart memcached, and plack 8. In the staff client remove the reservation you placed from the staff client. 9. Repeat step 3 and notice when you go to your opac summary (opac-user.pl) page the holds are displayed. .i.e. You can now successfully place item level holds in the OPAC. 10. Return to the opac-reserve.pl page for the biblio and notice that because you have already placed a hold on this biblio the 'Next available item' and 'A specific item' radiobuttons are disabled. 11. Select several of the items checkboxes to place more item level holds and press the 'Confirm hold' button. 12. Go to your opac summary (opac-user.pl) page again and notice the holds you placed in step 11 are shown there. i.e. you can place item level holds from the OPAC on biblios which have previously had reserves placed on them. Sponsored-By: Brimbank Library Signed-off-by: Katrin Fischer --- opac/opac-reserve.pl | 28 +++++++++++++++++++++++++--- 1 file changed, 25 insertions(+), 3 deletions(-) diff --git a/opac/opac-reserve.pl b/opac/opac-reserve.pl index 25fb74d..03197e6 100755 --- a/opac/opac-reserve.pl +++ b/opac/opac-reserve.pl @@ -44,6 +44,7 @@ use Koha::Libraries; use Koha::Patrons; use Date::Calc qw/Today Date_to_Days/; use List::MoreUtils qw/uniq/; +use Data::Dumper; my $maxreserves = C4::Context->preference("maxreserves"); @@ -191,6 +192,24 @@ if ( $query->param('place_reserve') ) { my @itemnumbers = $query->param("checkitem_$biblioNum"); my $branch = $query->param("branch_$biblioNum"); my $reqtype = $query->param("reqtype_$biblioNum"); + warn $biblioNum; + if (!$reqtype) { + #If no $reqtype value has been passed from the form this means both reqany and reqspecific radio buttons are disabled because a hold has been placed on this biblio previously and so a forced_hold_level exists. + # Determine what the forced_hold_level is. + my $holds = Koha::Holds->search( + { + borrowernumber => $borrowernumber, + biblionumber => $biblioNum, + found => undef, + } + ); + my $forced_hold_level = $holds->forced_hold_level(); + if ($forced_hold_level eq "item") { + $reqtype = "Specific"; + } elsif ($forced_hold_level eq "record") { + $reqtype = "Any"; + } + } my $holds_to_place_count = $query->param("holds_to_place_count_$biblioNum") || 1; my $notes = $query->param('notes_'.$biblioNum) || ''; my $nbRequested = $reqtype eq 'Specific' ? @itemnumbers : $holds_to_place_count; @@ -241,16 +260,18 @@ if ( $query->param('place_reserve') ) { if ( $hostbiblioNum ne $biblioNum ) { $biblionumber = $hostbiblioNum; } - - $canreserve = 0 unless CanItemBeReserved( $borrowernumber, $itemnumber ) eq 'OK'; + my $reservestatus = CanItemBeReserved( $borrowernumber, $itemnumber); + $canreserve = 0 if !($reservestatus->{status} eq 'OK'); $rank = '0' unless C4::Context->preference('ReservesNeedReturns'); my $item = GetItem($itemnumber); if ( $item->{'holdingbranch'} eq $branch ) { $found = 'W' unless C4::Context->preference('ReservesNeedReturns'); } - + warn $itemnumber; + warn $canreserve; if ($canreserve) { + warn $canreserve; my $reserve_id = AddReserve( $branch, $borrowernumber, $biblionumber, @@ -598,6 +619,7 @@ foreach my $biblioNum (@biblionumbers) { } ); my $forced_hold_level = $holds->forced_hold_level(); + warn $forced_hold_level; if ($forced_hold_level) { #$biblioLoopIter{force_hold} = 1 if $forced_hold_level eq 'item'; #$biblioLoopIter{itemholdable} = 0 if $forced_hold_level eq 'record'; -- 2.1.4