From 603bd79ce24cbdb06036292ff9705883a3869f49 Mon Sep 17 00:00:00 2001 From: Aleisha Amohia Date: Tue, 28 Aug 2018 23:39:56 +0000 Subject: [PATCH] Bug 15326: (follow-up) Code review fixes Addresses the following issues: b) In opac-cmspages there is: + flagsrequired => { borrow => 1 }, The borrow permission has been removed since. (blocker) c) Comment was removed unnecessarily, just needs to be moved into its right spot below again: -# If GoogleIndicTransliteration system preference is On Set parameter to load Google's javascript in OPAC search screens d) One file uses qw( -utf-8) but another does not: +use CGI; +use CGI qw( -utf8 ); (blocker) Signed-off-by: Michal Denar Signed-off-by: Michal Denar --- opac/opac-cmspages.pl | 3 +-- opac/opac-main.pl | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/opac/opac-cmspages.pl b/opac/opac-cmspages.pl index 1cc68d0c4f..ac31dae08d 100755 --- a/opac/opac-cmspages.pl +++ b/opac/opac-cmspages.pl @@ -18,7 +18,7 @@ # along with Koha; if not, see . use Modern::Perl; -use CGI; +use CGI qw( -utf8 ); use C4::Auth; use C4::Output; use C4::Languages qw( getTranslatedLanguages accept_language ); @@ -36,7 +36,6 @@ my ( $template, $borrowernumber, $cookie ) = get_template_and_user( type => "opac", query => $input, authnotrequired => ( C4::Context->preference( "OpacPublic" ) ? 1 : 0 ), - flagsrequired => { borrow => 1 }, } ); diff --git a/opac/opac-main.pl b/opac/opac-main.pl index 7b51da70c5..1fc5570eec 100755 --- a/opac/opac-main.pl +++ b/opac/opac-main.pl @@ -108,7 +108,7 @@ $template->param( parent_list => $parent_list, ); - +# If GoogleIndicTransliteration system preference is On Set parameter to load Google's javascript in OPAC search screens if (C4::Context->preference('GoogleIndicTransliteration')) { $template->param('GoogleIndicTransliteration' => 1); -- 2.11.0