From b236824dd6eca9c49edc4234ad592158726e4bb3 Mon Sep 17 00:00:00 2001 From: Aleisha Amohia Date: Wed, 29 Aug 2018 03:23:04 +0000 Subject: [PATCH] Bug 15326: (follow-up) Interface fixes This patch addresses the following: a) I feel we don't need the "Pages" heading. It only takes up space and states the obvious. (non-blocker... but navigation needs work, see below) b) OpacMainUserBlock should not show on the pages in my opinion. Libraries use it to place text on the start page instead of using the news feature, which means it repeats on all pages. I'd really like to see this changed. c) Personally I'd change "Location" to "Interface" to avoid confusion with the item value in translations. But I see it's the same on news. So out of scope here. d) Parent pages can be deleted without warning. Childs will be moved to top level. This is acceptable behaviour as they are not left orphaned. But it might be something to improve on in the future. e) In the test plan and in the code I see there should be a confirmation message on deleting a single or multiple entries, but this doesn't work. (blocker) Signed-off-by: Michal Denar Signed-off-by: Michal Denar --- .../prog/en/modules/tools/cmspages.tt | 22 ++++++++++++++-------- .../opac-tmpl/bootstrap/en/includes/navigation.inc | 1 - .../bootstrap/en/modules/opac-cmspages.tt | 1 - tools/cmspages.pl | 4 ++++ 4 files changed, 18 insertions(+), 10 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/cmspages.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/cmspages.tt index 4d76298edd..fb24bd7a3d 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/cmspages.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/cmspages.tt @@ -1,3 +1,4 @@ +[% USE raw %] [% USE KohaDates %] [% USE Koha %] [% USE Asset %] @@ -8,7 +9,6 @@ Koha › Tools › Pages [% INCLUDE 'doc-head-close.inc' %] [% Asset.css("css/datatables.css") %] -[% INCLUDE 'datatables.inc' %] [% INCLUDE 'header.inc' %] @@ -98,7 +98,7 @@ Page
  1. - + + + [% IF ( page.publish ) %]Yes[% ELSE %]No[% END %] [% page.parent.title_link %] [% SWITCH page.location %] @@ -238,7 +238,7 @@ Actions