Bugzilla – Attachment 83772 Details for
Bug 20959
Style checkin form more like the checkout form, with collapsed settings panel
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20959: (follow-up) Alternate: Add preventDefault to link controls
Bug-20959-follow-up-Alternate-Add-preventDefault-t.patch (text/plain), 1.45 KB, created by
Owen Leonard
on 2019-01-10 16:36:31 UTC
(
hide
)
Description:
Bug 20959: (follow-up) Alternate: Add preventDefault to link controls
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2019-01-10 16:36:31 UTC
Size:
1.45 KB
patch
obsolete
>From 9b1f314df0c8604f419170b2f8edfd4c029a5f6c Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Thu, 10 Jan 2019 16:33:56 +0000 >Subject: [PATCH] Bug 20959: (follow-up) Alternate: Add preventDefault to link > controls > >This patch adds a missing preventDefault to the function for showing and >hiding the checkin settings panel. This prevents the page from >unexpected scrolling when the link is clicked. > >To test, apply the patch and go to Circulation -> Check in. Reduce the >height of the browser window until you have to scroll down to reveal the >"Checkin settings" link. Clicking it should not cause the page to >scroll. >--- > koha-tmpl/intranet-tmpl/prog/js/pages/circulation.js | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/pages/circulation.js b/koha-tmpl/intranet-tmpl/prog/js/pages/circulation.js >index 8bfd667..45e381b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/pages/circulation.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/pages/circulation.js >@@ -66,7 +66,8 @@ $(document).ready(function() { > circ_settings_icon.removeClass("fa-caret-down").addClass("fa-caret-right"); > } > >- $("#show-circ-settings a").on("click",function(){ >+ $("#show-circ-settings a").on("click",function(e){ >+ e.preventDefault(); > if( circ_settings.is(":hidden")){ > circ_settings.show(); > circ_settings_icon.removeClass("fa-caret-right").addClass("fa-caret-down"); >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20959
:
76136
|
76137
|
76139
|
76526
|
76560
|
76561
|
78733
|
78734
|
78810
|
78812
|
78831
|
78839
|
78840
|
78841
|
79757
|
82995
|
82996
|
82997
|
83180
|
83772
|
86477
|
86729
|
87422
|
87933
|
87934
|
91081
|
91123
|
91164