From 01efc8ad8a6cd95247423cff6dd637e4d1adbf52 Mon Sep 17 00:00:00 2001
From: Kyle M Hall <kyle@bywatersolutions.com>
Date: Thu, 10 Jan 2019 14:32:22 -0500
Subject: [PATCH] Bug 22097: CataloguingLog should be suppressed for item
 branch transfers

Bug 18816 missed the fact that a branch transfer triggers ModItem and thus generates an action log line. We should not be creating those action logs, especially considering the transfers table itself already documents the transfer.

Test Plan:
1) Enable CataloguingLog
2) Transfer an item to another branch
3) Note the new action log line created
4) Apply this patch
5) Create another item transfer
6) No new action log line should be created!
---
 C4/Items.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/C4/Items.pm b/C4/Items.pm
index ce5d58341b..af68866b42 100644
--- a/C4/Items.pm
+++ b/C4/Items.pm
@@ -629,7 +629,7 @@ sub ModItemTransfer {
         VALUES (?, ?, NOW(), ?)");
     $sth->execute($itemnumber, $frombranch, $tobranch);
 
-    ModItem({ holdingbranch => $tobranch }, undef, $itemnumber);
+    ModItem({ holdingbranch => $tobranch }, undef, $itemnumber, { log_action => 0 });
     ModDateLastSeen($itemnumber);
     return;
 }
-- 
2.17.2 (Apple Git-113)