Bugzilla – Attachment 83925 Details for
Bug 22120
Add price formatting to patron summary print
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22120: Add price formattig to patron summary print
Bug-22120-Add-price-formattig-to-patron-summary-pr.patch (text/plain), 2.89 KB, created by
helene
on 2019-01-15 02:28:45 UTC
(
hide
)
Description:
Bug 22120: Add price formattig to patron summary print
Filename:
MIME Type:
Creator:
helene
Created:
2019-01-15 02:28:45 UTC
Size:
2.89 KB
patch
obsolete
>From 121c25ce102bef50852f60482482eb51d4fb408b Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer.83@web.de> >Date: Sun, 13 Jan 2019 11:15:27 +0100 >Subject: [PATCH] Bug 22120: Add price formattig to patron summary print > >The patron summary print lists the replacement prices >and rental charges of items and totals them. With this >patch they will be formatted according to the >CurrencyFormat system preference. > >To test: >- Find or create a patron with some checkouts >- Make sure some items have replacement price set > and some have a rental charge >- "Print summary" from the account in staff >- Verify that charges and prices in the checkouts > table are formatted correctly >- Toggle CurrencyFormat to different settings > >Signed-off-by: helene hickey <hickeyhe@wgc.school.nz> >--- > .../intranet-tmpl/prog/en/modules/members/moremember-print.tt | 8 ++++---- > members/summary-print.pl | 2 +- > 2 files changed, 5 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-print.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-print.tt >index dcf0cb4a33..10ee5574e0 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-print.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-print.tt >@@ -58,16 +58,16 @@ > <td>[% issue.itemtype_description | html %]</td> > <td>[% issue.date_due | $KohaDates as_due_date => 1 %]</td> > <td>[% issue.barcode | html %]</td> >- <td>[% issue.charge | html %]</td> >- <td>[% issue.replacementprice | html %]</td> >+ <td>[% issue.charge | $Price %]</td> >+ <td>[% issue.replacementprice | $Price %]</td> > <td>[% IF ( issue.overdue ) %]Overdue![% ELSE %] [% END %]</td> > </tr> > [% END %] > > <tr> > <td colspan="6" style="text-align: right; font-weight:bold;">Totals:</td> >- <td>[% totaldue | html %]</td> >- <td>[% totalprice | html %]</td> >+ <td>[% totaldue | $Price %]</td> >+ <td>[% totalprice | $Price %]</td> > <td colspan="3"> </td> > </tr> > </table> >diff --git a/members/summary-print.pl b/members/summary-print.pl >index 352b49755e..76bb1d4213 100755 >--- a/members/summary-print.pl >+++ b/members/summary-print.pl >@@ -96,7 +96,7 @@ sub build_issue_data { > $itemtype = Koha::ItemTypes->find( $itemtype ); > $checkout->{itemtype_description} = $itemtype->description; #FIXME Should not it be translated_description > >- $checkout->{charge} = sprintf( "%.2f", $charge ); # TODO Should be done in the template using Price >+ $checkout->{charge} = $charge; > > $checkout->{overdue} = $c->is_overdue; > >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22120
:
83840
|
83925
|
83926
|
83936
|
84011
|
84883