Bugzilla – Attachment 84028 Details for
Bug 22110
Editing adjustments doesn't work for Currencyformat != US
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22110: Fix editing of adjustments for CurrencyFormat != US
Bug-22110-Fix-editing-of-adjustments-for-CurrencyF.patch (text/plain), 2.13 KB, created by
Katrin Fischer
on 2019-01-15 22:00:15 UTC
(
hide
)
Description:
Bug 22110: Fix editing of adjustments for CurrencyFormat != US
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2019-01-15 22:00:15 UTC
Size:
2.13 KB
patch
obsolete
>From 5504173a5b74b084a27fcbb5caa46d76ebe07986 Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer.83@web.de> >Date: Mon, 14 Jan 2019 12:47:25 +0000 >Subject: [PATCH] Bug 22110: Fix editing of adjustments for CurrencyFormat != > US > >When using CurrencyFormat FR or CH the editing an amount behave >badly. Example: changing displayed 1,00 to 1,11 would save as 1,00. > >At the moment Koha only understands decimal dot, not comma. >So every time data is entered, we use decimal dot. > >1) Add an adjustment to an invoice >2) Change system preference CurrencyFormat to FR or CH >3) Verify the amount displays with a decimal comma >4) Try changing the amount to something like 1,11 >5) Save the amount >6) Verify it shows 1.00 >7) Apply patch >8) Refresh the invoice page if necessary >9) Verify amount is now shown as 1.00 >10) Repeat test, use 1.11 >11) Verify it will be stored correctly. >--- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt >index 4cfad00e6b..5dab779f98 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt >@@ -109,7 +109,7 @@ > [% total_adj = total_adj + adjustment.adjustment %] > <tr> > <td><input type="hidden" name="adjustment_id" value="[% adjustment.adjustment_id | html %]" />[% adjustment.adjustment_id | html %]</td> >- <td><input type="text" name="adjustment" id="adjustment_[% adjustment.adjustment_id | html %]" value="[% adjustment.adjustment | $Price %]" /></td> >+ <td><input type="text" name="adjustment" id="adjustment_[% adjustment.adjustment_id | html %]" value="[% adjustment.adjustment | $Price on_editing => 1 %]" /></td> > <td> > [% reasons = AuthorisedValues.Get("ADJ_REASON") %] > [% IF reasons.0 %] >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22110
:
84028
|
84161
|
84221
|
84881