Bugzilla – Attachment 84267 Details for
Bug 22118
Format hold fee when placing holds in OPAC
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22118: Format hold fee when placing holds in OPAC
Bug-22118-Format-hold-fee-when-placing-holds-in-OP.patch (text/plain), 2.77 KB, created by
Josef Moravec
on 2019-01-21 15:43:29 UTC
(
hide
)
Description:
Bug 22118: Format hold fee when placing holds in OPAC
Filename:
MIME Type:
Creator:
Josef Moravec
Created:
2019-01-21 15:43:29 UTC
Size:
2.77 KB
patch
obsolete
>From eb0e9eb7a4d989396d6ffa54cb3a134e56faa35d Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer.83@web.de> >Date: Sat, 12 Jan 2019 09:21:38 +0100 >Subject: [PATCH] Bug 22118: Format hold fee when placing holds in OPAC > >When Koha charges for holds, a message with the fee is >shown before the patron places the hold. The amount needs >to be formatted according to CurrencyFormat system preference. > >To test: >- Add a hold fee to your patron category >- Log into the OPAC >- Search for a record to place a hold on >- Click Place hold >- Verify there is a note showing about the hold fee >- Toggle CurrencyFormat and HoldFeeMode and verify > that the formatting is always correct > >Signed-off-by: Jack Kelliher <jke0429@stacmail.net> >Signed-off-by: Mikael Olangcay Brisebois <mikael.olangcay-brisebois@inlibro.com> > >Signed-off-by: Josef Moravec <josef.moravec@gmail.com> >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt | 4 ++-- > opac/opac-reserve.pl | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt >index d4c4d689c9..fe7f1b27b0 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt >@@ -130,9 +130,9 @@ > [% IF (RESERVE_CHARGE) %] > <div class="alert" id="reserve_fee"> > [% IF Koha.Preference('HoldFeeMode') == 'any_time_is_collected' %] >- You will be charged a hold fee of [% RESERVE_CHARGE | html %] when you collect this item >+ You will be charged a hold fee of [% RESERVE_CHARGE | $Price %] when you collect this item > [% ELSE %] >- You will be charged a hold fee of [% RESERVE_CHARGE | html %] for placing this hold >+ You will be charged a hold fee of [% RESERVE_CHARGE | $Price %] for placing this hold > [% END %] > </div> > [% END %] >diff --git a/opac/opac-reserve.pl b/opac/opac-reserve.pl >index df13dc1c74..2e2bde081a 100755 >--- a/opac/opac-reserve.pl >+++ b/opac/opac-reserve.pl >@@ -101,7 +101,7 @@ if ( $patron->category->effective_BlockExpiredPatronOpacActions ) { > # Pass through any reserve charge > my $reservefee = $patron->category->reservefee; > if ( $reservefee > 0){ >- $template->param( RESERVE_CHARGE => sprintf("%.2f",$reservefee)); >+ $template->param( RESERVE_CHARGE => $reservefee); > } > > my $itemtypes = { map { $_->{itemtype} => $_ } @{ Koha::ItemTypes->search_with_localization->unblessed } }; >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22118
:
83838
|
83920
|
84231
| 84267