View | Details | Raw Unified | Return to bug 21798
Collapse All | Expand All

(-)a/t/db_dependent/Circulation.t (-9 / +9 lines)
Lines 213-219 $dbh->do( Link Here
213
# CanBookBeRenewed tests
213
# CanBookBeRenewed tests
214
    C4::Context->set_preference('ItemsDeniedRenewal','');
214
    C4::Context->set_preference('ItemsDeniedRenewal','');
215
    # Generate test biblio
215
    # Generate test biblio
216
    my $biblio = $builder->gimme_a_biblio();
216
    my $biblio = $builder->build_sample_biblio();
217
217
218
    my $barcode = 'R00000342';
218
    my $barcode = 'R00000342';
219
    my $branch = $library2->{branchcode};
219
    my $branch = $library2->{branchcode};
Lines 906-912 $dbh->do( Link Here
906
    my $branch   = $library2->{branchcode};
906
    my $branch   = $library2->{branchcode};
907
907
908
    #Create another record
908
    #Create another record
909
    my $biblio2 = $builder->gimme_a_biblio();
909
    my $biblio2 = $builder->build_sample_biblio();
910
910
911
    #Create third item
911
    #Create third item
912
    AddItem(
912
    AddItem(
Lines 985-991 $dbh->do( Link Here
985
    my $barcode  = '1234567890';
985
    my $barcode  = '1234567890';
986
    my $branch   = $library2->{branchcode};
986
    my $branch   = $library2->{branchcode};
987
987
988
    my $biblio = $builder->gimme_a_biblio();
988
    my $biblio = $builder->build_sample_biblio();
989
989
990
    #Create third item
990
    #Create third item
991
    my ( undef, undef, $itemnumber ) = AddItem(
991
    my ( undef, undef, $itemnumber ) = AddItem(
Lines 1042-1048 $dbh->do( Link Here
1042
        undef,  0,
1042
        undef,  0,
1043
        .10, 1
1043
        .10, 1
1044
    );
1044
    );
1045
    my $biblio = $builder->gimme_a_biblio();
1045
    my $biblio = $builder->build_sample_biblio();
1046
1046
1047
    my $barcode1 = '1234';
1047
    my $barcode1 = '1234';
1048
    my ( undef, undef, $itemnumber1 ) = AddItem(
1048
    my ( undef, undef, $itemnumber1 ) = AddItem(
Lines 1125-1131 $dbh->do( Link Here
1125
    my $branch   = $library->{branchcode};
1125
    my $branch   = $library->{branchcode};
1126
1126
1127
    #Create another record
1127
    #Create another record
1128
    my $biblio = $builder->gimme_a_biblio();
1128
    my $biblio = $builder->build_sample_biblio();
1129
1129
1130
    my (undef, undef, $itemnumber) = AddItem(
1130
    my (undef, undef, $itemnumber) = AddItem(
1131
        {
1131
        {
Lines 1155-1161 $dbh->do( Link Here
1155
{
1155
{
1156
    my $library = $builder->build({ source => 'Branch' });
1156
    my $library = $builder->build({ source => 'Branch' });
1157
1157
1158
    my $biblio = $builder->gimme_a_biblio();
1158
    my $biblio = $builder->build_sample_biblio();
1159
1159
1160
    my $barcode = 'just a barcode';
1160
    my $barcode = 'just a barcode';
1161
    my ( undef, undef, $itemnumber ) = AddItem(
1161
    my ( undef, undef, $itemnumber ) = AddItem(
Lines 1455-1461 subtest 'CanBookBeIssued + Statistic patrons "X"' => sub { Link Here
1455
subtest 'MultipleReserves' => sub {
1455
subtest 'MultipleReserves' => sub {
1456
    plan tests => 3;
1456
    plan tests => 3;
1457
1457
1458
    my $biblio = $builder->gimme_a_biblio();
1458
    my $biblio = $builder->build_sample_biblio();
1459
1459
1460
    my $branch = $library2->{branchcode};
1460
    my $branch = $library2->{branchcode};
1461
1461
Lines 1992-1998 subtest '_FixAccountForLostAndReturned' => sub { Link Here
1992
    );
1992
    );
1993
    my $library = $builder->build_object( { class => 'Koha::Libraries' } );
1993
    my $library = $builder->build_object( { class => 'Koha::Libraries' } );
1994
1994
1995
    my $biblio = $builder->gimme_a_biblio({ author => 'Hall, Daria' });
1995
    my $biblio = $builder->build_sample_biblio({ author => 'Hall, Daria' });
1996
1996
1997
    subtest 'Full write-off tests' => sub {
1997
    subtest 'Full write-off tests' => sub {
1998
1998
Lines 2357-2363 subtest '_FixAccountForLostAndReturned' => sub { Link Here
2357
subtest '_FixOverduesOnReturn' => sub {
2357
subtest '_FixOverduesOnReturn' => sub {
2358
    plan tests => 10;
2358
    plan tests => 10;
2359
2359
2360
    my $biblio = $builder->gimme_a_biblio({ author => 'Hall, Kylie' });
2360
    my $biblio = $builder->build_sample_biblio({ author => 'Hall, Kylie' });
2361
2361
2362
    my $barcode = 'KD987654321';
2362
    my $barcode = 'KD987654321';
2363
    my $branchcode  = $library2->{branchcode};
2363
    my $branchcode  = $library2->{branchcode};
(-)a/t/db_dependent/Holds.t (-11 / +11 lines)
Lines 54-60 $insert_sth->execute('DUMMY'); Link Here
54
$insert_sth->execute('ONLY1');
54
$insert_sth->execute('ONLY1');
55
55
56
# Setup Test------------------------
56
# Setup Test------------------------
57
my $biblio = $builder->gimme_a_biblio({ itemtype => 'DUMMY' });
57
my $biblio = $builder->build_sample_biblio({ itemtype => 'DUMMY' });
58
58
59
# Create item instance for testing.
59
# Create item instance for testing.
60
my ($item_bibnum, $item_bibitemnum, $itemnumber)
60
my ($item_bibnum, $item_bibitemnum, $itemnumber)
Lines 239-245 is( $hold->priority, '6', "Test AlterPriority(), move to bottom" ); Link Here
239
# Note that canreservefromotherbranches has no effect if
239
# Note that canreservefromotherbranches has no effect if
240
# IndependentBranches is OFF.
240
# IndependentBranches is OFF.
241
241
242
my $foreign_biblio = $builder->gimme_a_biblio({ itemtype => 'DUMMY' });
242
my $foreign_biblio = $builder->build_sample_biblio({ itemtype => 'DUMMY' });
243
my ($foreign_item_bibnum, $foreign_item_bibitemnum, $foreign_itemnumber)
243
my ($foreign_item_bibnum, $foreign_item_bibitemnum, $foreign_itemnumber)
244
  = AddItem({ homebranch => $branch_2, holdingbranch => $branch_2 } , $foreign_biblio->biblionumber);
244
  = AddItem({ homebranch => $branch_2, holdingbranch => $branch_2 } , $foreign_biblio->biblionumber);
245
$dbh->do('DELETE FROM issuingrules');
245
$dbh->do('DELETE FROM issuingrules');
Lines 284-290 ok( Link Here
284
284
285
{
285
{
286
    # Regression test for bug 11336 # Test if ModReserve correctly recalculate the priorities
286
    # Regression test for bug 11336 # Test if ModReserve correctly recalculate the priorities
287
    $biblio = $builder->gimme_a_biblio({ itemtype => 'DUMMY' });
287
    $biblio = $builder->build_sample_biblio({ itemtype => 'DUMMY' });
288
    ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem({ homebranch => $branch_1, holdingbranch => $branch_1 } , $biblio->biblionumber);
288
    ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem({ homebranch => $branch_1, holdingbranch => $branch_1 } , $biblio->biblionumber);
289
    my $reserveid1 = AddReserve($branch_1, $borrowernumbers[0], $biblio->biblionumber, '', 1);
289
    my $reserveid1 = AddReserve($branch_1, $borrowernumbers[0], $biblio->biblionumber, '', 1);
290
    ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem({ homebranch => $branch_1, holdingbranch => $branch_1 } , $biblio->biblionumber);
290
    ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem({ homebranch => $branch_1, holdingbranch => $branch_1 } , $biblio->biblionumber);
Lines 321-327 ok( CanItemBeReserved( $borrowernumbers[0], $itemnumber)->{status} eq 'damaged', Link Here
321
ok( !defined( ( CheckReserves($itemnumber) )[1] ), "Hold cannot be trapped for damaged item with AllowHoldsOnDamagedItems disabled" );
321
ok( !defined( ( CheckReserves($itemnumber) )[1] ), "Hold cannot be trapped for damaged item with AllowHoldsOnDamagedItems disabled" );
322
322
323
# Regression test for bug 9532
323
# Regression test for bug 9532
324
$biblio = $builder->gimme_a_biblio({ itemtype => 'CANNOT' });
324
$biblio = $builder->build_sample_biblio({ itemtype => 'CANNOT' });
325
($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem({ homebranch => $branch_1, holdingbranch => $branch_1, itype => 'CANNOT' } , $biblio->biblionumber);
325
($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem({ homebranch => $branch_1, holdingbranch => $branch_1, itype => 'CANNOT' } , $biblio->biblionumber);
326
AddReserve(
326
AddReserve(
327
    $branch_1,
327
    $branch_1,
Lines 369-375 $dbh->do(q{ Link Here
369
    INSERT INTO branch_item_rules (branchcode, itemtype, holdallowed, returnbranch)
369
    INSERT INTO branch_item_rules (branchcode, itemtype, holdallowed, returnbranch)
370
    VALUES (?, ?, ?, ?)
370
    VALUES (?, ?, ?, ?)
371
}, {}, $branch_1, 'CAN', 1, 'homebranch');
371
}, {}, $branch_1, 'CAN', 1, 'homebranch');
372
$biblio = $builder->gimme_a_biblio({ itemtype => 'CANNOT' });
372
$biblio = $builder->build_sample_biblio({ itemtype => 'CANNOT' });
373
($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem(
373
($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem(
374
    { homebranch => $branch_1, holdingbranch => $branch_1, itype => 'CANNOT' } , $biblio->biblionumber);
374
    { homebranch => $branch_1, holdingbranch => $branch_1, itype => 'CANNOT' } , $biblio->biblionumber);
375
is(CanItemBeReserved($borrowernumbers[0], $itemnumber)->{status}, 'notReservable',
375
is(CanItemBeReserved($borrowernumbers[0], $itemnumber)->{status}, 'notReservable',
Lines 395-401 $dbh->do('DELETE FROM issues'); Link Here
395
$dbh->do('DELETE FROM items');
395
$dbh->do('DELETE FROM items');
396
$dbh->do('DELETE FROM biblio');
396
$dbh->do('DELETE FROM biblio');
397
397
398
$biblio = $builder->gimme_a_biblio({ itemtype => 'ONLY1' });
398
$biblio = $builder->build_sample_biblio({ itemtype => 'ONLY1' });
399
( $item_bibnum, $item_bibitemnum, $itemnumber )
399
( $item_bibnum, $item_bibitemnum, $itemnumber )
400
    = AddItem( { homebranch => $branch_1, holdingbranch => $branch_1 }, $biblio->biblionumber );
400
    = AddItem( { homebranch => $branch_1, holdingbranch => $branch_1 }, $biblio->biblionumber );
401
401
Lines 420-426 subtest 'Test max_holds per library/patron category' => sub { Link Here
420
    $dbh->do('DELETE FROM issuingrules');
420
    $dbh->do('DELETE FROM issuingrules');
421
    $dbh->do('DELETE FROM circulation_rules');
421
    $dbh->do('DELETE FROM circulation_rules');
422
422
423
    $biblio = $builder->gimme_a_biblio({ itemtype => 'TEST' });
423
    $biblio = $builder->build_sample_biblio({ itemtype => 'TEST' });
424
    ( $item_bibnum, $item_bibitemnum, $itemnumber ) =
424
    ( $item_bibnum, $item_bibitemnum, $itemnumber ) =
425
      AddItem( { homebranch => $branch_1, holdingbranch => $branch_1 },
425
      AddItem( { homebranch => $branch_1, holdingbranch => $branch_1 },
426
        $biblio->biblionumber );
426
        $biblio->biblionumber );
Lines 490-496 subtest 'Test max_holds per library/patron category' => sub { Link Here
490
subtest 'Pickup location availability tests' => sub {
490
subtest 'Pickup location availability tests' => sub {
491
    plan tests => 4;
491
    plan tests => 4;
492
492
493
    $biblio = $builder->gimme_a_biblio({ itemtype => 'ONLY1' });
493
    $biblio = $builder->build_sample_biblio({ itemtype => 'ONLY1' });
494
    my ( $item_bibnum, $item_bibitemnum, $itemnumber )
494
    my ( $item_bibnum, $item_bibitemnum, $itemnumber )
495
    = AddItem( { homebranch => $branch_1, holdingbranch => $branch_1 }, $biblio->biblionumber );
495
    = AddItem( { homebranch => $branch_1, holdingbranch => $branch_1 }, $biblio->biblionumber );
496
    #Add a default rule to allow some holds
496
    #Add a default rule to allow some holds
Lines 547-567 subtest 'CanItemBeReserved / holds_per_day tests' => sub { Link Here
547
    my $patron   = $builder->build_object( { class => 'Koha::Patrons' } );
547
    my $patron   = $builder->build_object( { class => 'Koha::Patrons' } );
548
548
549
    # Create 3 biblios with items
549
    # Create 3 biblios with items
550
    my $biblio_1 = $builder->gimme_a_biblio({ itemtype => $itemtype->itemtype });
550
    my $biblio_1 = $builder->build_sample_biblio({ itemtype => $itemtype->itemtype });
551
    my ( undef, undef, $itemnumber_1 ) = AddItem(
551
    my ( undef, undef, $itemnumber_1 ) = AddItem(
552
        {   homebranch    => $library->branchcode,
552
        {   homebranch    => $library->branchcode,
553
            holdingbranch => $library->branchcode
553
            holdingbranch => $library->branchcode
554
        },
554
        },
555
        $biblio_1->biblionumber
555
        $biblio_1->biblionumber
556
    );
556
    );
557
    my $biblio_2 = $builder->gimme_a_biblio({ itemtype => $itemtype->itemtype });
557
    my $biblio_2 = $builder->build_sample_biblio({ itemtype => $itemtype->itemtype });
558
    my ( undef, undef, $itemnumber_2 ) = AddItem(
558
    my ( undef, undef, $itemnumber_2 ) = AddItem(
559
        {   homebranch    => $library->branchcode,
559
        {   homebranch    => $library->branchcode,
560
            holdingbranch => $library->branchcode
560
            holdingbranch => $library->branchcode
561
        },
561
        },
562
        $biblio_2->biblionumber
562
        $biblio_2->biblionumber
563
    );
563
    );
564
    my $biblio_3 = $builder->gimme_a_biblio({ itemtype => $itemtype->itemtype });
564
    my $biblio_3 = $builder->build_sample_biblio({ itemtype => $itemtype->itemtype });
565
    my ( undef, undef, $itemnumber_3 ) = AddItem(
565
    my ( undef, undef, $itemnumber_3 ) = AddItem(
566
        {   homebranch    => $library->branchcode,
566
        {   homebranch    => $library->branchcode,
567
            holdingbranch => $library->branchcode
567
            holdingbranch => $library->branchcode
(-)a/t/db_dependent/Holds/LocalHoldsPriority.t (-1 / +1 lines)
Lines 40-46 my $itemtype = $builder->build( Link Here
40
40
41
my $borrowers_count = 5;
41
my $borrowers_count = 5;
42
42
43
my $biblio = $builder->gimme_a_biblio();
43
my $biblio = $builder->build_sample_biblio();
44
my ( $item_bibnum, $item_bibitemnum, $itemnumber ) = AddItem(
44
my ( $item_bibnum, $item_bibitemnum, $itemnumber ) = AddItem(
45
    {   homebranch    => $library4->{branchcode},
45
    {   homebranch    => $library4->{branchcode},
46
        holdingbranch => $library3->{branchcode},
46
        holdingbranch => $library3->{branchcode},
(-)a/t/db_dependent/Holds/RevertWaitingStatus.t (-1 / +1 lines)
Lines 46-52 t::lib::Mocks::mock_userenv({ flags => 1, userid => '1', branchcode => $branchco Link Here
46
46
47
my $borrowers_count = 3;
47
my $borrowers_count = 3;
48
48
49
my $biblio = $builder->gimme_a_biblio();
49
my $biblio = $builder->build_sample_biblio();
50
my $item_barcode = 'my_barcode';
50
my $item_barcode = 'my_barcode';
51
my ( $item_bibnum, $item_bibitemnum, $itemnumber ) = AddItem(
51
my ( $item_bibnum, $item_bibitemnum, $itemnumber ) = AddItem(
52
    {   homebranch    => $branchcode,
52
    {   homebranch    => $branchcode,
(-)a/t/db_dependent/Items.t (-9 / +9 lines)
Lines 56-62 subtest 'General Add, Get and Del tests' => sub { Link Here
56
56
57
    # Create a biblio instance for testing
57
    # Create a biblio instance for testing
58
    t::lib::Mocks::mock_preference('marcflavour', 'MARC21');
58
    t::lib::Mocks::mock_preference('marcflavour', 'MARC21');
59
    my $biblio = $builder->gimme_a_biblio();
59
    my $biblio = $builder->build_sample_biblio();
60
60
61
    # Add an item.
61
    # Add an item.
62
    my ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem({ homebranch => $library->{branchcode}, holdingbranch => $library->{branchcode}, location => $location, itype => $itemtype->{itemtype} } , $biblio->biblionumber);
62
    my ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem({ homebranch => $library->{branchcode}, holdingbranch => $library->{branchcode}, location => $location, itype => $itemtype->{itemtype} } , $biblio->biblionumber);
Lines 168-174 subtest 'GetHiddenItemnumbers tests' => sub { Link Here
168
168
169
    # Create a new biblio
169
    # Create a new biblio
170
    t::lib::Mocks::mock_preference('marcflavour', 'MARC21');
170
    t::lib::Mocks::mock_preference('marcflavour', 'MARC21');
171
    my $biblio = $builder->gimme_a_biblio();
171
    my $biblio = $builder->build_sample_biblio();
172
172
173
    # Add two items
173
    # Add two items
174
    my ( $item1_bibnum, $item1_bibitemnum, $item1_itemnumber ) = AddItem(
174
    my ( $item1_bibnum, $item1_bibitemnum, $item1_itemnumber ) = AddItem(
Lines 266-272 subtest 'GetItemsInfo tests' => sub { Link Here
266
    });
266
    });
267
267
268
    # Add a biblio
268
    # Add a biblio
269
    my $biblio = $builder->gimme_a_biblio();
269
    my $biblio = $builder->build_sample_biblio();
270
    # Add an item
270
    # Add an item
271
    my ( $item_bibnum, $item_bibitemnum, $itemnumber ) = AddItem(
271
    my ( $item_bibnum, $item_bibitemnum, $itemnumber ) = AddItem(
272
        {
272
        {
Lines 357-364 subtest 'SearchItems test' => sub { Link Here
357
    t::lib::Mocks::mock_preference('marcflavour', 'MARC21');
357
    t::lib::Mocks::mock_preference('marcflavour', 'MARC21');
358
    my $cpl_items_before = SearchItemsByField( 'homebranch', $library1->{branchcode});
358
    my $cpl_items_before = SearchItemsByField( 'homebranch', $library1->{branchcode});
359
359
360
    my $biblio = $builder->gimme_a_biblio({ title => 'Silence in the library' });
360
    my $biblio = $builder->build_sample_biblio({ title => 'Silence in the library' });
361
    $builder->gimme_a_biblio({ title => 'Silence in the shadow' });
361
    $builder->build_sample_biblio({ title => 'Silence in the shadow' });
362
362
363
    my (undef, $initial_items_count) = SearchItems(undef, {rows => 1});
363
    my (undef, $initial_items_count) = SearchItems(undef, {rows => 1});
364
364
Lines 535-541 subtest 'Koha::Item(s) tests' => sub { Link Here
535
535
536
    # Create a biblio and item for testing
536
    # Create a biblio and item for testing
537
    t::lib::Mocks::mock_preference('marcflavour', 'MARC21');
537
    t::lib::Mocks::mock_preference('marcflavour', 'MARC21');
538
    my $biblio = $builder->gimme_a_biblio();
538
    my $biblio = $builder->build_sample_biblio();
539
    my ( $item_bibnum, $item_bibitemnum, $itemnumber ) = AddItem(
539
    my ( $item_bibnum, $item_bibitemnum, $itemnumber ) = AddItem(
540
        {
540
        {
541
            homebranch    => $library1->{branchcode},
541
            homebranch    => $library1->{branchcode},
Lines 576-582 subtest 'C4::Biblio::EmbedItemsInMarcBiblio' => sub { Link Here
576
        source => 'Itemtype',
576
        source => 'Itemtype',
577
    });
577
    });
578
578
579
    my $biblio = $builder->gimme_a_biblio();
579
    my $biblio = $builder->build_sample_biblio();
580
    my $item_infos = [
580
    my $item_infos = [
581
        { homebranch => $library1->{branchcode}, holdingbranch => $library1->{branchcode} },
581
        { homebranch => $library1->{branchcode}, holdingbranch => $library1->{branchcode} },
582
        { homebranch => $library1->{branchcode}, holdingbranch => $library1->{branchcode} },
582
        { homebranch => $library1->{branchcode}, holdingbranch => $library1->{branchcode} },
Lines 703-709 subtest 'C4::Items::_build_default_values_for_mod_marc' => sub { Link Here
703
    my $itemtype = $builder->build({ source => 'Itemtype' })->{itemtype};
703
    my $itemtype = $builder->build({ source => 'Itemtype' })->{itemtype};
704
704
705
    # Create a record with a barcode
705
    # Create a record with a barcode
706
    my $biblio = $builder->gimme_a_biblio({ frameworkcode => $framework->{frameworkcode} });
706
    my $biblio = $builder->build_sample_biblio({ frameworkcode => $framework->{frameworkcode} });
707
    my $item_record = new MARC::Record;
707
    my $item_record = new MARC::Record;
708
    my $a_barcode = 'a barcode';
708
    my $a_barcode = 'a barcode';
709
    my $barcode_field = MARC::Field->new(
709
    my $barcode_field = MARC::Field->new(
Lines 849-855 subtest 'Test logging for ModItem' => sub { Link Here
849
849
850
    # Create a biblio instance for testing
850
    # Create a biblio instance for testing
851
    t::lib::Mocks::mock_preference('marcflavour', 'MARC21');
851
    t::lib::Mocks::mock_preference('marcflavour', 'MARC21');
852
    my $biblio = $builder->gimme_a_biblio();
852
    my $biblio = $builder->build_sample_biblio();
853
853
854
    # Add an item.
854
    # Add an item.
855
    my ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem({ homebranch => $library->{branchcode}, holdingbranch => $library->{branchcode}, location => $location, itype => $itemtype->{itemtype} } , $biblio->biblionumber);
855
    my ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem({ homebranch => $library->{branchcode}, holdingbranch => $library->{branchcode}, location => $location, itype => $itemtype->{itemtype} } , $biblio->biblionumber);
(-)a/t/db_dependent/Items/DelItem.t (-1 / +1 lines)
Lines 16-22 my $library = $builder->build({ Link Here
16
    source => 'Branch',
16
    source => 'Branch',
17
});
17
});
18
18
19
my $biblio = $builder->gimme_a_biblio();
19
my $biblio = $builder->build_sample_biblio();
20
20
21
my ( $item_bibnum, $item_bibitemnum, $itemnumber );
21
my ( $item_bibnum, $item_bibitemnum, $itemnumber );
22
( $item_bibnum, $item_bibitemnum, $itemnumber ) =
22
( $item_bibnum, $item_bibitemnum, $itemnumber ) =
(-)a/t/db_dependent/Items/GetItemsForInventory.t (-2 / +2 lines)
Lines 74-81 subtest 'Skip items with waiting holds' => sub { Link Here
74
    my $title_1 = 'Title 1, ';
74
    my $title_1 = 'Title 1, ';
75
    my $title_2 = 'Title 2, bizzarre one so doesn\'t already exist';
75
    my $title_2 = 'Title 2, bizzarre one so doesn\'t already exist';
76
76
77
    my $biblio_1 = $builder->gimme_a_biblio({ itemtype => $itemtype->itemtype, title => $title_1 });
77
    my $biblio_1 = $builder->build_sample_biblio({ itemtype => $itemtype->itemtype, title => $title_1 });
78
    my $biblio_2 = $builder->gimme_a_biblio({ itemtype => $itemtype->itemtype, title => $title_2 });
78
    my $biblio_2 = $builder->build_sample_biblio({ itemtype => $itemtype->itemtype, title => $title_2 });
79
79
80
    my ( $items_1, $first_items_count ) = GetItemsForInventory();
80
    my ( $items_1, $first_items_count ) = GetItemsForInventory();
81
    is( scalar @{$items_1}, $first_items_count, 'Results and count match' );
81
    is( scalar @{$items_1}, $first_items_count, 'Results and count match' );
(-)a/t/db_dependent/Koha/BiblioUtils/Iterator.t (-1 / +1 lines)
Lines 47-53 my $itemtype = $builder->build({ Link Here
47
47
48
# Create a biblio instance for testing
48
# Create a biblio instance for testing
49
t::lib::Mocks::mock_preference('marcflavour', 'MARC21');
49
t::lib::Mocks::mock_preference('marcflavour', 'MARC21');
50
my $biblio = $builder->gimme_a_biblio();
50
my $biblio = $builder->build_sample_biblio();
51
51
52
# Add an item.
52
# Add an item.
53
my ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem({ homebranch => $library->{branchcode}, holdingbranch => $library->{branchcode}, location => $location, itype => $itemtype->{itemtype} } , $biblio->biblionumber);
53
my ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem({ homebranch => $library->{branchcode}, holdingbranch => $library->{branchcode}, location => $location, itype => $itemtype->{itemtype} } , $biblio->biblionumber);
(-)a/t/db_dependent/Koha/Biblios.t (-1 / +1 lines)
Lines 143-149 subtest 'can_be_transferred' => sub { Link Here
143
    my $library1 = $builder->build_object( { class => 'Koha::Libraries' } );
143
    my $library1 = $builder->build_object( { class => 'Koha::Libraries' } );
144
    my $library2 = $builder->build_object( { class => 'Koha::Libraries' } );
144
    my $library2 = $builder->build_object( { class => 'Koha::Libraries' } );
145
    my $library3 = $builder->build_object( { class => 'Koha::Libraries' } );
145
    my $library3 = $builder->build_object( { class => 'Koha::Libraries' } );
146
    my $biblio = $builder->gimme_a_biblio({ itemtype => 'ONLY1' });
146
    my $biblio = $builder->build_sample_biblio({ itemtype => 'ONLY1' });
147
    my ($item_bibnum, $item_bibitemnum, $itemnumber)
147
    my ($item_bibnum, $item_bibitemnum, $itemnumber)
148
        = AddItem({ homebranch => $library1->branchcode, holdingbranch => $library1->branchcode }, $biblio->biblionumber);
148
        = AddItem({ homebranch => $library1->branchcode, holdingbranch => $library1->branchcode }, $biblio->biblionumber);
149
    my $item  = Koha::Items->find($itemnumber);
149
    my $item  = Koha::Items->find($itemnumber);
(-)a/t/db_dependent/Labels/t_Label.t (-1 / +1 lines)
Lines 59-65 my $itemtype = Link Here
59
59
60
t::lib::Mocks::mock_userenv({ branchcode => $branch_1 });
60
t::lib::Mocks::mock_userenv({ branchcode => $branch_1 });
61
61
62
my $bibnum = $builder->gimme_a_biblio({ frameworkcode => $frameworkcode })->biblionumber;
62
my $bibnum = $builder->build_sample_biblio({ frameworkcode => $frameworkcode })->biblionumber;
63
63
64
# Create a helper item instance for testing
64
# Create a helper item instance for testing
65
my ( $item_bibnum, $item_bibitemnum, $itemnumber ) = AddItem(
65
my ( $item_bibnum, $item_bibitemnum, $itemnumber ) = AddItem(
(-)a/t/db_dependent/OAI/Sets.t (-4 / +4 lines)
Lines 355-364 ok (!defined(AddOAISetsBiblios(my $arg=[])), 'AddOAISetsBiblios with a no HASH a Link Here
355
ok (defined(AddOAISetsBiblios($arg={})), 'AddOAISetsBiblios with a HASH argument is def');
355
ok (defined(AddOAISetsBiblios($arg={})), 'AddOAISetsBiblios with a HASH argument is def');
356
356
357
# Create a biblio instance for testing
357
# Create a biblio instance for testing
358
my $biblio_1 = $builder->gimme_a_biblio({ author => 'Moffat, Steven' });
358
my $biblio_1 = $builder->build_sample_biblio({ author => 'Moffat, Steven' });
359
my $biblionumber1 = $biblio_1->biblionumber;
359
my $biblionumber1 = $biblio_1->biblionumber;
360
isa_ok(\$biblionumber1, 'SCALAR', '$biblionumber1 is a SCALAR');
360
isa_ok(\$biblionumber1, 'SCALAR', '$biblionumber1 is a SCALAR');
361
my $biblio_2 = $builder->gimme_a_biblio({ author => 'Moffat, Steven' });
361
my $biblio_2 = $builder->build_sample_biblio({ author => 'Moffat, Steven' });
362
my $biblionumber2 = $biblio_2->biblionumber;
362
my $biblionumber2 = $biblio_2->biblionumber;
363
isa_ok(\$biblionumber2, 'SCALAR', '$biblionumber2 is a SCALAR');
363
isa_ok(\$biblionumber2, 'SCALAR', '$biblionumber2 is a SCALAR');
364
364
Lines 521-527 ModOAISetMappings($setVH_id, $mappingsVH); Link Here
521
521
522
522
523
#Create a biblio notice corresponding at one of mappings
523
#Create a biblio notice corresponding at one of mappings
524
my $biblio_VH = $builder->gimme_a_biblio({ author => 'Victor Hugo' });
524
my $biblio_VH = $builder->build_sample_biblio({ author => 'Victor Hugo' });
525
my $biblionumberVH = $biblio_VH->biblionumber;
525
my $biblionumberVH = $biblio_VH->biblionumber;
526
526
527
#Update
527
#Update
Lines 577-583 ModOAISetMappings($setNotVH_id, $mappingsNotVH); Link Here
577
577
578
578
579
#Create a biblio notice corresponding at one of mappings
579
#Create a biblio notice corresponding at one of mappings
580
my $biblio_NotVH = $builder->gimme_a_biblio({ author => 'Sponge, Bob' });
580
my $biblio_NotVH = $builder->build_sample_biblio({ author => 'Sponge, Bob' });
581
my $biblionumberNotVH = $biblio_NotVH->biblionumber;
581
my $biblionumberNotVH = $biblio_NotVH->biblionumber;
582
582
583
#Update
583
#Update
(-)a/t/db_dependent/Reserves.t (-2 / +2 lines)
Lines 79-85 my $itemtype = $builder->build( Link Here
79
79
80
t::lib::Mocks::mock_userenv({ branchcode => $branch_1 });
80
t::lib::Mocks::mock_userenv({ branchcode => $branch_1 });
81
81
82
my $bibnum = $builder->gimme_a_biblio({frameworkcode => $frameworkcode})->biblionumber;
82
my $bibnum = $builder->build_sample_biblio({frameworkcode => $frameworkcode})->biblionumber;
83
83
84
# Create a helper item instance for testing
84
# Create a helper item instance for testing
85
my ( $item_bibnum, $item_bibitemnum, $itemnumber ) = AddItem(
85
my ( $item_bibnum, $item_bibitemnum, $itemnumber ) = AddItem(
Lines 212-218 $dbh->do( Link Here
212
    $branch_2, 10, 2, 'homebranch',
212
    $branch_2, 10, 2, 'homebranch',
213
);
213
);
214
214
215
my $bibnum2 = $builder->gimme_a_biblio({frameworkcode => $frameworkcode})->biblionumber;
215
my $bibnum2 = $builder->build_sample_biblio({frameworkcode => $frameworkcode})->biblionumber;
216
216
217
my ($itemnum_cpl, $itemnum_fpl);
217
my ($itemnum_cpl, $itemnum_fpl);
218
( undef, undef, $itemnum_cpl ) = AddItem(
218
( undef, undef, $itemnum_cpl ) = AddItem(
(-)a/t/db_dependent/Serials.t (-1 / +1 lines)
Lines 143-149 subtest 'Values should not be erased on editing' => sub { Link Here
143
143
144
    plan tests => 1;
144
    plan tests => 1;
145
145
146
    my $biblio = $builder->gimme_a_biblio();
146
    my $biblio = $builder->build_sample_biblio();
147
    my $biblionumber = $biblio->biblionumber;
147
    my $biblionumber = $biblio->biblionumber;
148
    my ( $icn_tag, $icn_sf ) = GetMarcFromKohaField( 'items.itemcallnumber', '' );
148
    my ( $icn_tag, $icn_sf ) = GetMarcFromKohaField( 'items.itemcallnumber', '' );
149
    my ( $it_tag, $it_sf )   = GetMarcFromKohaField( 'items.itype', '' );
149
    my ( $it_tag, $it_sf )   = GetMarcFromKohaField( 'items.itype', '' );
(-)a/t/lib/TestBuilder.pm (-2 / +1 lines)
Lines 127-133 sub build { Link Here
127
    });
127
    });
128
}
128
}
129
129
130
sub gimme_a_biblio {
130
sub build_sample_biblio {
131
    my ( $self, $args ) = @_;
131
    my ( $self, $args ) = @_;
132
132
133
    my $title  = $args->{title}  || 'Some boring read';
133
    my $title  = $args->{title}  || 'Some boring read';
134
- 

Return to bug 21798