Bugzilla – Attachment 84629 Details for
Bug 22195
Change default DataTables configuration to consolidate buttons
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22195: (follow-up) Add text labels to buttons if window is wide enough
Bug-22195-follow-up-Add-text-labels-to-buttons-if-.patch (text/plain), 2.53 KB, created by
Owen Leonard
on 2019-02-01 14:23:35 UTC
(
hide
)
Description:
Bug 22195: (follow-up) Add text labels to buttons if window is wide enough
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2019-02-01 14:23:35 UTC
Size:
2.53 KB
patch
obsolete
>From a31d3d5fab0cf1502bc15f7a2c9bf9203e6fcb16 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Fri, 1 Feb 2019 14:12:18 +0000 >Subject: [PATCH] Bug 22195: (follow-up) Add text labels to buttons if window > is wide enough > >This patch adds responsive handling of text labels to the columns >configuration and export buttons. > >To test, apply the patch and clear your browser cache if necessary. > > - View a page with column configuration, e.g. Administration -> Patron > categories. > - At wider browser widths the buttons should have text labels. > - At narrower browser widths the labels should be hidden. >--- > koha-tmpl/intranet-tmpl/prog/css/datatables.css | 10 ++++++++++ > koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc | 4 ++-- > 2 files changed, 12 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/css/datatables.css b/koha-tmpl/intranet-tmpl/prog/css/datatables.css >index ae93c7e..4b6aa76 100644 >--- a/koha-tmpl/intranet-tmpl/prog/css/datatables.css >+++ b/koha-tmpl/intranet-tmpl/prog/css/datatables.css >@@ -301,3 +301,13 @@ table.group tr.even td { > button.dt-button, div.dt-button, a.dt-button { > margin: 3px 3px 0; > } >+ >+.dt-button-text { >+ display: none; >+} >+ >+@media (min-width: 1028px) { >+ .dt-button-text { >+ display: inline; >+ } >+} >\ No newline at end of file >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc >index cdca0fa..a0989a3 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc >@@ -65,7 +65,7 @@ function KohaTable(id_selector, dt_parameters, columns_settings, add_filters) { > columns: included_ids, > className: "columns_controls", > titleAttr: _("Columns settings"), >- text: '<i class="fa fa-lg fa-gear"></i>', >+ text: '<i class="fa fa-lg fa-gear"></i> <span class="dt-button-text">' + _("Columns") + '</span>', > exportOptions: { > columns: exportColumns > }, >@@ -75,7 +75,7 @@ function KohaTable(id_selector, dt_parameters, columns_settings, add_filters) { > fade: 100, > className: "export_controls", > titleAttr: _("Export or print"), >- text: '<i class="fa fa-lg fa-download"></i>', >+ text: '<i class="fa fa-lg fa-download"></i> <span class="dt-button-text">' + _("Export") + '</span>', > buttons: export_buttons > } > >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22195
:
84336
|
84337
|
84391
|
84442
|
84443
|
84450
| 84629