Bugzilla – Attachment 84669 Details for
Bug 19915
Inventory tool doesn't use cn_sort for callnumber ranges
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19915: Don't delete in tests
Bug-19915-Dont-delete-in-tests.patch (text/plain), 1.85 KB, created by
Katrin Fischer
on 2019-02-02 17:06:34 UTC
(
hide
)
Description:
Bug 19915: Don't delete in tests
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2019-02-02 17:06:34 UTC
Size:
1.85 KB
patch
obsolete
>From 98af031af666110fdff0fe29fe6cce79e322de4c Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Thu, 1 Nov 2018 13:11:16 +0000 >Subject: [PATCH] Bug 19915: Don't delete in tests > >https://bugs.koha-community.org/show_bug.cgi?id=19905 > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > t/db_dependent/Items/GetItemsForInventory.t | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/Items/GetItemsForInventory.t b/t/db_dependent/Items/GetItemsForInventory.t >index 85e2bf99c2..edd1e976ee 100755 >--- a/t/db_dependent/Items/GetItemsForInventory.t >+++ b/t/db_dependent/Items/GetItemsForInventory.t >@@ -143,7 +143,6 @@ subtest 'Use cn_sort rather than callnumber to determine correct location' => su > plan tests => 1; > > my $builder = t::lib::TestBuilder->new; >- Koha::Items->delete; > > my $class_rule = $builder->build({ > source => 'ClassSortRule', >@@ -155,6 +154,14 @@ subtest 'Use cn_sort rather than callnumber to determine correct location' => su > class_sort_rule => $class_rule->{class_sort_rule}, > } > }); >+ >+ #Find if we have any items in our test range before we start >+ my( undef, $pre_item_count) = GetItemsForInventory({ >+ maxlocation => 'GT100', >+ minlocation => 'GT90', >+ class_source => $class_source->{cn_source}, >+ }); >+ > my $item_1 = $builder->build({ > source => 'Item', > value => { >@@ -168,7 +175,7 @@ subtest 'Use cn_sort rather than callnumber to determine correct location' => su > minlocation => 'GT90', > class_source => $class_source->{cn_source}, > }); >- is($item_count,1,"We should return GT95 as between GT90 and GT100"); >+ is($item_count,$pre_item_count + 1,"We should return GT95 as between GT90 and GT100"); > $schema->storage->txn_rollback; > > }; >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19915
:
70274
|
70275
|
70338
|
70339
|
72950
|
72951
|
72988
|
72989
|
76120
|
76721
|
76722
|
76723
|
76724
|
81816
|
81817
|
81818
|
81819
|
81820
|
81821
|
83644
|
83645
|
83646
|
83647
|
83648
|
83649
|
84665
|
84666
|
84667
|
84668
| 84669 |
84670