From d5266629b48e448baef42232ea69a3a9df92b6b0 Mon Sep 17 00:00:00 2001 From: Alex Arnaud Date: Tue, 13 Nov 2018 09:44:51 +0100 Subject: [PATCH] Bug 21738: check items count in C4:ILSDI::HoldTitle Test plan: - Try holding a title without items via ILS-DI (cgi-bin/koha/ilsdi.pl?service=HoldTitle&patron_id=1&bib_id=1), - you get an error, - apply this patch, - try again, - you should get the code "Notitems"Bug 21738: check items count in C4:ILSDI::HoldTitle Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Signed-off-by: Katrin Fischer --- C4/ILSDI/Services.pm | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/C4/ILSDI/Services.pm b/C4/ILSDI/Services.pm index 89b8dab42c..1ffdc14419 100644 --- a/C4/ILSDI/Services.pm +++ b/C4/ILSDI/Services.pm @@ -660,6 +660,18 @@ sub HoldTitle { my $biblio = Koha::Biblios->find( $biblionumber ); return { code => 'RecordNotFound' } unless $biblio; + my @hostitems = get_hostitemnumbers_of($biblionumber); + my @itemnumbers; + if (@hostitems){ + push(@itemnumbers, @hostitems); + } + + my $items = Koha::Items->search({ -or => { biblionumber => $biblionumber, itemnumber => { in => \@itemnumbers } } }); + + unless ( $items->count ) { + return { code => 'NoItems' }; + } + my $title = $biblio ? $biblio->title : ''; # Check if the biblio can be reserved -- 2.11.0