Bugzilla – Attachment 84948 Details for
Bug 18393
Statistics wizard for acquisitions not filtering correctly by collection code
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18939: Acquisition statistics - Fix wrong template variable name for collection filter
Bug-18939-Acquisition-statistics---Fix-wrong-templ.patch (text/plain), 1.82 KB, created by
Katrin Fischer
on 2019-02-10 19:57:27 UTC
(
hide
)
Description:
Bug 18939: Acquisition statistics - Fix wrong template variable name for collection filter
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2019-02-10 19:57:27 UTC
Size:
1.82 KB
patch
obsolete
>From 8ccafbcb953595673f2beaccab1d68f5694e1f65 Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer.83@web.de> >Date: Wed, 6 Feb 2019 11:43:52 +0000 >Subject: [PATCH] Bug 18939: Acquisition statistics - Fix wrong template > variable name for collection filter > >The template variable was wrong, so the filter never submitted the >collection code for the query. > >Before: ><option value="">Fiction</option> ><option value="">Non-fiction</option> > >After: ><option value="FIC">Fiction</option> ><option value="NFIC">Non-fiction</option> > >To test: >- Go to Reports > Statistics wizards > Acquisitions >- Pick a row and column >- Compare results with and without collection filter >- Verify the table is always the same >- Apply patch >- Repeat comparison, verify the filter works now > >https://bugs.koha-community.org/show_bug.cgi?id=18393 >--- > koha-tmpl/intranet-tmpl/prog/en/modules/reports/acquisitions_stats.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/acquisitions_stats.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/acquisitions_stats.tt >index 5180b54e56..c1ad99bfa4 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/acquisitions_stats.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/acquisitions_stats.tt >@@ -175,7 +175,7 @@ > <select name="Filter"> > <option value="" selected="selected">All</option> > [% FOREACH ccode_av IN ccode_avlist %] >- <option value="[% ccode_av.value | html %]">[% ccode_av.lib | html %]</option> >+ <option value="[% ccode_av.authorised_value | html %]">[% ccode_av.lib | html %]</option> > [% END %] > </select> > [% ELSE %] >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18393
:
61929
|
61930
|
61931
|
84948
|
85023