From 38101114034cb03c060fb9098fcc55345f8efa37 Mon Sep 17 00:00:00 2001 From: Katrin Fischer <katrin.fischer.83@web.de> Date: Wed, 6 Feb 2019 11:43:52 +0000 Subject: [PATCH] Bug 18939: Acquisition statistics - Fix wrong template variable name for collection filter The template variable was wrong, so the filter never submitted the collection code for the query. Before: <option value="">Fiction</option> <option value="">Non-fiction</option> After: <option value="FIC">Fiction</option> <option value="NFIC">Non-fiction</option> To test: - Go to Reports > Statistics wizards > Acquisitions - Pick a row and column - Compare results with and without collection filter - Verify the table is always the same - Apply patch - Repeat comparison, verify the filter works now https://bugs.koha-community.org/show_bug.cgi?id=18393 Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> --- .../intranet-tmpl/prog/en/modules/reports/acquisitions_stats.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/acquisitions_stats.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/acquisitions_stats.tt index 5180b54e56..c1ad99bfa4 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/acquisitions_stats.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/acquisitions_stats.tt @@ -175,7 +175,7 @@ <select name="Filter"> <option value="" selected="selected">All</option> [% FOREACH ccode_av IN ccode_avlist %] - <option value="[% ccode_av.value | html %]">[% ccode_av.lib | html %]</option> + <option value="[% ccode_av.authorised_value | html %]">[% ccode_av.lib | html %]</option> [% END %] </select> [% ELSE %] -- 2.20.1