Bugzilla – Attachment 85130 Details for
Bug 20334
Elasticsearch - Option for escaping slashes in search queries
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20334: Improve syspref description and set more sensible defaults
Bug-20334-Improve-syspref-description-and-set-more.patch (text/plain), 2.78 KB, created by
David Gustafsson
on 2019-02-14 16:41:41 UTC
(
hide
)
Description:
Bug 20334: Improve syspref description and set more sensible defaults
Filename:
MIME Type:
Creator:
David Gustafsson
Created:
2019-02-14 16:41:41 UTC
Size:
2.78 KB
patch
obsolete
>From f0dca6d2277a0db336cf49b4d61e8dead60e5e8b Mon Sep 17 00:00:00 2001 >From: David Gustafsson <david.gustafsson@ub.gu.se> >Date: Mon, 22 Oct 2018 15:50:07 +0200 >Subject: [PATCH] Bug 20334: Improve syspref description and set more sensible > defaults > >--- > .../atomicupdate/bug_20334-add-syspref-QueryRegexEscapeOptions.sql | 2 +- > .../intranet-tmpl/prog/en/modules/admin/preferences/searching.pref | 3 ++- > 2 files changed, 3 insertions(+), 2 deletions(-) > >diff --git a/installer/data/mysql/atomicupdate/bug_20334-add-syspref-QueryRegexEscapeOptions.sql b/installer/data/mysql/atomicupdate/bug_20334-add-syspref-QueryRegexEscapeOptions.sql >index 7f70795631..e43d1c377c 100644 >--- a/installer/data/mysql/atomicupdate/bug_20334-add-syspref-QueryRegexEscapeOptions.sql >+++ b/installer/data/mysql/atomicupdate/bug_20334-add-syspref-QueryRegexEscapeOptions.sql >@@ -1 +1 @@ >-INSERT IGNORE INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `type`) VALUES ('QueryRegexEscapeOptions', 'dont_escape', 'dont_escape|escape|unescape_escaped', 'Escape option for regexps delimiters in Elasicsearch queries.', 'Choice'); >+INSERT IGNORE INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `type`) VALUES ('QueryRegexEscapeOptions', 'escape', 'dont_escape|escape|unescape_escaped', 'Escape option for regexps delimiters in Elasicsearch queries.', 'Choice'); >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/searching.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/searching.pref >index c44f4d0e4e..154960e0c0 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/searching.pref >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/searching.pref >@@ -31,11 +31,12 @@ Searching: > - ranking of search results by relevance (REQUIRES ZEBRA). > - > - pref: QueryRegexEscapeOptions >+ default: escape > choices: > escape: Escape > unescape_escaped: Unescape escaped > dont_escape: Don't escape >- - "regular expressions within query strings. If \"Unescape escaped\" is selected this will allow writing regular expressions \"\/like this\/\" while \"/this/\", \"or/this\" will be escaped and interpreted by Elasticsearch as regular strings." >+ - "regular expressions within query strings. If \"Escape\" is selected occurences of \"/\" in search terms will be automatically escaped, and regular expressions interpreted as regular strings. If \"Unescape escaped\" is selected this will allow writing regular expressions \"\/like this\/\" while \"/this/\", \"or/this\" will be escaped and interpreted as regular strings. (Elasticsearch only.)" > - > - pref: OpacGroupResults > default: 0 >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20334
:
72434
|
72435
|
72471
|
72830
|
73222
|
80978
|
81517
|
81597
|
81613
|
85129
|
85130
|
85131
|
93478
|
93584
|
93585
|
93586
|
93664
|
93665
|
93666
|
93697
|
93699
|
93700