Bugzilla – Attachment 85150 Details for
Bug 19832
SIP checkout removes extra hold on same biblio
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19832: Don't fill holds in SIP/Transaction/Checkout.pm
Bug-19832-Dont-fill-holds-in-SIPTransactionCheckou.patch (text/plain), 2.05 KB, created by
Marcel de Rooy
on 2019-02-15 10:12:54 UTC
(
hide
)
Description:
Bug 19832: Don't fill holds in SIP/Transaction/Checkout.pm
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2019-02-15 10:12:54 UTC
Size:
2.05 KB
patch
obsolete
>From 8ac6aaf778ee83190d2f843d6b999c863ee07dc8 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Wed, 16 Jan 2019 13:19:45 +0000 >Subject: [PATCH] Bug 19832: Don't fill holds in SIP/Transaction/Checkout.pm >Content-Type: text/plain; charset=utf-8 > >AddIssue already checks for holds in the item being issued and deals with them > >The sip code, additionally, does not consider that multiple holds per bib >is allowed > >To test: > 0 - Apply only first patch (unit tests) > 1 - Place two holds for a patron on a bib > 2 - Checkout that item via sip_cli_emulator > 3 - Note all holds are cancelled/filled > 4 - prove -v t/db_dependent/SIP/Transaction.t > 5 - it fails > 6 - Apply second patch > 7 - prove tests, all green > 8 - Place two holds on a single bib for one patron again > 9 - Checkout the item via sip_cli_emulator >10 - Only one holds is filled > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > C4/SIP/ILS/Transaction/Checkout.pm | 9 --------- > 1 file changed, 9 deletions(-) > >diff --git a/C4/SIP/ILS/Transaction/Checkout.pm b/C4/SIP/ILS/Transaction/Checkout.pm >index 23cdec92c4..09028ab14c 100644 >--- a/C4/SIP/ILS/Transaction/Checkout.pm >+++ b/C4/SIP/ILS/Transaction/Checkout.pm >@@ -129,15 +129,6 @@ sub do_checkout { > $self->ok(0); > return $self; > } >- # Fill any reserves the patron had on the item. >- # TODO: this logic should be pulled internal to AddIssue for all Koha. >- $debug and warn "pending_queue: " . (@$pending) ? Dumper($pending) : '[]'; >- foreach (grep {$_->{borrowernumber} eq $self->{patron}->{borrowernumber}} @$pending) { >- $debug and warn "Filling reserve (borrowernumber,biblionumber,reservedate): " >- . sprintf("(%s,%s,%s)\n",$_->{borrowernumber},$_->{biblionumber},$_->{reservedate}); >- ModReserveFill($_); >- # TODO: adjust representation in $self->item >- } > # can issue > $debug and warn "do_checkout: calling AddIssue(\$borrower,$barcode, $overridden_duedate, 0)\n" > # . "w/ \$borrower: " . Dumper($borrower) >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19832
:
84070
|
84071
|
84180
|
84181
|
85149
| 85150 |
85151