From 14ed35ea1b582649f67ba77467ffbc4c1194f8ef Mon Sep 17 00:00:00 2001 From: Katrin Fischer Date: Wed, 6 Feb 2019 04:31:28 +0000 Subject: [PATCH] Bug 21335: Remove redundant includes of right-to-left.css Fixes redundant includes of the right-to-left.css file. There is no need to include it in the .tt files as it's part of the doc-head-close.inc. Note: Make sure your *BaseURL preferences are correctly set as this will make the switching between languages work correctly and throw you back to the start page otherwise every time you switch Test: - Install an RTL language like Arabic (ar-Arab) - Test various pages with English and RTL language: - Authorities home page - Adding a new bibliographic record - Adding a new item or editing items - Advanced cataloguing (Rancor) editor - Labels start page - OPAC detail page - Verify display is correct and right-to-left.css is available Signed-off-by: Owen Leonard --- koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt | 3 --- koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt | 3 --- koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt | 3 --- koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/editor.tt | 3 --- koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-home.tt | 3 --- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 3 --- 6 files changed, 18 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt index b0856b9..2a626c0 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt @@ -168,9 +168,6 @@ function confirmnotdup(redirect){ }); -[% IF ( bidi ) %] - [% Asset.css("css/right-to-left.css") | $raw %] -[% END %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt index 41326ab..de2429b 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt @@ -405,9 +405,6 @@ function Changefwk() { }); -[% IF ( bidi ) %] - [% Asset.css("css/right-to-left.css") | $raw %] -[% END %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt index 4aaf0f7..af69265 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt @@ -140,9 +140,6 @@ function confirm_deletion() { }); -[% IF ( bidi ) %] - [% Asset.css("css/right-to-left.css") | $raw %] -[% END %] [% INCLUDE 'header.inc' %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/editor.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/editor.tt index c80943d..21fd4da 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/editor.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/editor.tt @@ -9,9 +9,6 @@ [% Asset.css("css/humanmsg.css") | $raw %] [% Asset.js("js/cataloging.js") | $raw %] [% Asset.js("lib/jquery/plugins/humanmsg.js") | $raw %] -[% IF ( bidi ) %] - [% Asset.css("css/right-to-left.css") | $raw %] -[% END %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-home.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-home.tt index eb5b9f3..f4898fc 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-home.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-home.tt @@ -4,9 +4,6 @@ [% INCLUDE 'doc-head-open.inc' %] Koha › Tools › Label creator [% INCLUDE 'doc-head-close.inc' %] - [% IF ( bidi ) %] - [% Asset.css("css/right-to-left.css") | $raw %] - [% END %] [% INCLUDE 'header.inc' %] diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt index d8a93cb..ed54b3a 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt @@ -32,9 +32,6 @@ [% INCLUDE 'doc-head-open.inc' %] [% IF ( LibraryNameTitle ) %][% LibraryNameTitle | html %][% ELSE %]Koha online[% END %] catalog › Details for: [% title | html %][% FOREACH subtitl IN subtitle %][% IF Koha.Preference('marcflavour')=='UNIMARC' %],[% END %] [% subtitl.subfield | html %][% END %] [% INCLUDE 'doc-head-close.inc' %] -[% IF ( bidi ) %] - [% BLOCK cssinclude %][% Asset.css("css/right-to-left.css") | $raw %][% END %] -[% END %] [% IF ( OpacStarRatings != 'disable' ) %] [% BLOCK cssinclude %][% Asset.css("css/jquery.rating.css") | $raw %][% END %] [% END %] -- 2.1.4