Bugzilla – Attachment 85467 Details for
Bug 22389
Classification splitting sources regex - cannot consistentlyadd/delete
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22389: (bug 15836 follow-up) Add Delete regex links on creating splitting source
Bug-22389-bug-15836-follow-up-Add-Delete-regex-lin.patch (text/plain), 1.62 KB, created by
Nick Clemens
on 2019-02-21 17:08:26 UTC
(
hide
)
Description:
Bug 22389: (bug 15836 follow-up) Add Delete regex links on creating splitting source
Filename:
MIME Type:
Creator:
Nick Clemens
Created:
2019-02-21 17:08:26 UTC
Size:
1.62 KB
patch
obsolete
>From 90bc4da3d5ea537227ef204457da9c39e7eb1b35 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 21 Feb 2019 13:42:30 -0300 >Subject: [PATCH] Bug 22389: (bug 15836 follow-up) Add Delete regex links on > creating splitting source > >The "Delete" link does not exist when the form is empty. > >Test plan: >Create a new classification splitting source >Select "Regex" for routine >=> The delete link does not appear (you cannot remove if there is only >one input) >=> It a regex >=> The 2 delete links appear > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt >index 9f8a375324..a023321ac7 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt >@@ -254,6 +254,7 @@ > [% ELSE %] > <div class="split_regex"> > <input type="text" name="split_regex" id="split_regex" value="" /> >+ <a href="#" title="Delete" class="del_regex"><i class="fa fa-fw fa-trash"></i>Delete</a> > </div> > [% END %] > </div> >@@ -400,6 +401,7 @@ > > $(document).ready(function(){ > update_regex_block(); >+ update_delete_links_visibility(); > $("#split_routine").on("change", function(){ > update_regex_block(); > }); >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22389
:
85457
| 85467