Bugzilla – Attachment 85764 Details for
Bug 21846
Using emoji as tags doesn't discriminate between emoji when calculating weights or searching
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21846: Simplify ugly double for loops
Bug-21846-Simplify-ugly-double-for-loops.patch (text/plain), 938 bytes, created by
Josef Moravec
on 2019-02-27 11:24:04 UTC
(
hide
)
Description:
Bug 21846: Simplify ugly double for loops
Filename:
MIME Type:
Creator:
Josef Moravec
Created:
2019-02-27 11:24:04 UTC
Size:
938 bytes
patch
obsolete
>From 80f155c49c82cd05a223dbd3c517dbe73f1434f6 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 26 Feb 2019 17:01:41 -0300 >Subject: [PATCH] Bug 21846: Simplify ugly double for loops > >Signed-off-by: Josef Moravec <josef.moravec@gmail.com> >--- > t/db_dependent/Tags.t | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/Tags.t b/t/db_dependent/Tags.t >index 0952e9a4f7..93014bb3c1 100755 >--- a/t/db_dependent/Tags.t >+++ b/t/db_dependent/Tags.t >@@ -89,8 +89,8 @@ subtest 'add_tag_index() tests' => sub { > 'ð' => 1, > }; > >- for my $term ( keys %{ $terms } ) { >- for (my $i=1; $i <= $terms->{$term}; $i++) { >+ while ( my ( $term, $count ) = each %$terms ) { >+ for ( 1 .. $count ) { > C4::Tags::add_tag_approval( $term ); > C4::Tags::add_tag_index( $term, $biblio->biblionumber ); > } >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21846
:
82621
|
82622
|
82623
|
83717
|
83759
|
83760
|
83761
|
83762
|
85730
|
85740
|
85741
|
85758
|
85759
|
85760
|
85761
|
85762
|
85763
| 85764