From 34f9907be5e8f90ae6a3ef183c6d292481a8d528 Mon Sep 17 00:00:00 2001
From: Kyle M Hall <kyle@bywatersolutions.com>
Date: Thu, 25 Aug 2016 14:03:31 +0000
Subject: [PATCH] Bug 10300: Allow transferring of items to be have separate
 IndependentBranches syspref

Some libraries want to have IndependentBranches enabled, but still be
able to transfer items between themselves.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Enable IndpendentBranches and IndependentBranchesTransfers
4) Log in as a super librarian
5) Note you can transfer items
6) Log in as a non-super librarian
7) Note you cannot transfer items
8) Disable IndependentBranchesTransfers
9) Note you can now transfer items

Signed-off-by: Maribeth Shafer <mshafer@ckls.org>
---
 installer/data/mysql/atomicupdate/bug_10300.sql            | 3 +++
 installer/data/mysql/sysprefs.sql                          | 1 +
 .../prog/en/modules/admin/preferences/admin.pref           | 7 +++++++
 3 files changed, 11 insertions(+)
 create mode 100644 installer/data/mysql/atomicupdate/bug_10300.sql

diff --git a/installer/data/mysql/atomicupdate/bug_10300.sql b/installer/data/mysql/atomicupdate/bug_10300.sql
new file mode 100644
index 0000000000..1bcf5d91c1
--- /dev/null
+++ b/installer/data/mysql/atomicupdate/bug_10300.sql
@@ -0,0 +1,3 @@
+INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `type` )
+SELECT 'IndependentBranchesTransfers', value, NULL, 'Allow non-superlibrarians to transfer items between libraries','YesNo'
+FROM systempreferences WHERE variable = 'IndependentBranches';
diff --git a/installer/data/mysql/sysprefs.sql b/installer/data/mysql/sysprefs.sql
index d142b14a0e..a1702b9469 100644
--- a/installer/data/mysql/sysprefs.sql
+++ b/installer/data/mysql/sysprefs.sql
@@ -224,6 +224,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `
 ('IncludeSeeFromInSearches','0','','Include see-from references in searches.','YesNo'),
 ('IndependentBranches','0',NULL,'If ON, increases security between libraries','YesNo'),
 ('IndependentBranchesPatronModifications','0', NULL, 'Show only modification request for the logged in branch','YesNo'),
+('IndependentBranchesTransfers','0', NULL, 'Allow non-superlibrarians to transfer items between libraries','YesNo'),
 ('IntranetCatalogSearchPulldown','0', NULL, 'Show a search field pulldown for \"Search the catalog\" boxes','YesNo'),
 ('RecordedBooksClientSecret','','30','Client key for RecordedBooks integration','YesNo'),
 ('RecordedBooksDomain','','','RecordedBooks domain','Free'),
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref
index 464c8c8e6a..32645aba5f 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref
@@ -111,6 +111,13 @@ Administration:
               choices:
                   yes: "Yes"
                   no: "No"
+        -
+            - Prevent staff (but not superlibrarians) from transfering items to other libraries
+            - pref: IndependentBranchesTransfers
+              default: 0
+              choices:
+                  yes: "Yes"
+                  no: "No"
     CAS authentication:
         -
             - "Use CAS for login authentication: "
-- 
2.17.1