From cad03415847568a830430176271b50696c1c396a Mon Sep 17 00:00:00 2001 From: Josef Moravec Date: Tue, 5 Mar 2019 14:08:34 +0000 Subject: [PATCH] Bug 18925: (QA follow-up) Fix Circulation.t Test plan: t/db_dependent/Circulation.t Signed-off-by: Josef Moravec --- t/db_dependent/Circulation.t | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t index eafc2d8e46..1312a6051b 100755 --- a/t/db_dependent/Circulation.t +++ b/t/db_dependent/Circulation.t @@ -1730,7 +1730,6 @@ subtest 'AddReturn + suspension_chargeperiod' => sub { categorycode => '*', itemtype => '*', branchcode => '*', - maxissueqty => 99, issuelength => 1, firstremind => 0, # 0 day of grace finedays => 2, # 2 days of fine per day of overdue @@ -1896,7 +1895,6 @@ subtest 'AddReturn | is_overdue' => sub { categorycode => '*', itemtype => '*', branchcode => '*', - maxissueqty => 99, issuelength => 6, lengthunit => 'days', fine => 1, # Charge 1 every day of overdue @@ -2500,12 +2498,12 @@ subtest 'CanBookBeIssued | is_overdue' => sub { $dbh->do('DELETE FROM issuingrules'); $dbh->do( q{INSERT INTO issuingrules (categorycode, branchcode, itemtype, reservesallowed, - maxissueqty, issuelength, lengthunit, + issuelength, lengthunit, renewalsallowed, renewalperiod, norenewalbefore, auto_renew, fine, chargeperiod) VALUES (?, ?, ?, ?, - ?, ?, ?, + ?, ?, ?, ?, ?, ?, ?, ? @@ -2513,7 +2511,7 @@ subtest 'CanBookBeIssued | is_overdue' => sub { }, {}, '*', '*', '*', 25, - 1, 14, 'days', + 14, 'days', 1, 7, undef, 0, .10, 1 @@ -2555,12 +2553,12 @@ subtest 'ItemsDeniedRenewal preference' => sub { my $idr_lib = $builder->build_object({ class => 'Koha::Libraries'}); $dbh->do( q{ - INSERT INTO issuingrules ( categorycode, branchcode, itemtype, reservesallowed, maxissueqty, issuelength, lengthunit, renewalsallowed, renewalperiod, - norenewalbefore, auto_renew, fine, chargeperiod ) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ? ) + INSERT INTO issuingrules ( categorycode, branchcode, itemtype, reservesallowed, issuelength, lengthunit, renewalsallowed, renewalperiod, + norenewalbefore, auto_renew, fine, chargeperiod ) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ? ) }, {}, '*', $idr_lib->branchcode, '*', 25, - 20, 14, 'days', + 14, 'days', 10, 7, undef, 0, .10, 1 -- 2.11.0