Bugzilla – Attachment 86086 Details for
Bug 21307
Switch two-column templates to Bootstrap grid: Cataloging
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21307: (follow-up) Change the way Codemirror height is calculated
Bug-21307-follow-up-Change-the-way-Codemirror-heig.patch (text/plain), 1.52 KB, created by
Owen Leonard
on 2019-03-05 14:56:58 UTC
(
hide
)
Description:
Bug 21307: (follow-up) Change the way Codemirror height is calculated
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2019-03-05 14:56:58 UTC
Size:
1.52 KB
patch
obsolete
>From d43a855af26c65bf9c4bddcd1ca19ea7b370daac Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Tue, 5 Mar 2019 14:53:18 +0000 >Subject: [PATCH] Bug 21307: (follow-up) Change the way Codemirror height is > calculated > >This follow-up changes the way the height of the Codemirror editor is >calculated. Using offset() instead of position() returns the correct >values with the changed markup. > >To test, apply the patch and load the advanced MARC editor. The "status >bar" should display correctly a the bottom of the editor and there >should be no double scrollbar. >--- > koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc >index 5bf7472..6c7f79f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc >@@ -785,7 +785,7 @@ require( [ 'koha-backend', 'search', 'macros', 'marc-editor', 'marc-record', 'pr > if ( resizeTimer == null ) resizeTimer = setTimeout( function() { > resizeTimer = null; > >- var pos = $('#editor .CodeMirror').position(); >+ var pos = $('#editor .CodeMirror').offset(); > $('#editor .CodeMirror').height( $(window).height() - pos.top - 24 - $('#changelanguage').height() ); // 24 is hardcoded value but works well > > $('.modal-body').each( function() { >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21307
:
78358
|
78428
|
86085
|
86086
|
86109
|
86462
|
86463
|
86464
|
87949
|
87950
|
87951
|
88134
|
88135
|
88136