From 83e255f2d69b558d659bb3f1663cd89a01b2121b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Radek=20=C5=A0iman?= Date: Tue, 1 Nov 2016 08:20:30 +0100 Subject: [PATCH] Bug 17509: Added NotifyToReturnItemWhenHoldIsPlaced syspref This system preference will allow to ask patrons to return items whenever a new hold is placed on them Test plan: 1) Open System preferences / Circulation / Holds Policy 2) Change value from Enable to Don't enable and vice versa 3) Check NotifyToReturnItemWhenHoldIsPlaced is changed in database 4) change which patrons will be contacted 5) compare your change against database value NotifyToReturnItemFromLibrary Signed-off-by: Josef Moravec --- ..._17509-add_NotifyToReturnItemWhenHoldIsPlaced_syspref.sql | 2 ++ installer/data/mysql/sysprefs.sql | 2 ++ .../prog/en/modules/admin/preferences/circulation.pref | 12 ++++++++++++ 3 files changed, 16 insertions(+) create mode 100644 installer/data/mysql/atomicupdate/bug_17509-add_NotifyToReturnItemWhenHoldIsPlaced_syspref.sql diff --git a/installer/data/mysql/atomicupdate/bug_17509-add_NotifyToReturnItemWhenHoldIsPlaced_syspref.sql b/installer/data/mysql/atomicupdate/bug_17509-add_NotifyToReturnItemWhenHoldIsPlaced_syspref.sql new file mode 100644 index 0000000000..2eb7e2f62d --- /dev/null +++ b/installer/data/mysql/atomicupdate/bug_17509-add_NotifyToReturnItemWhenHoldIsPlaced_syspref.sql @@ -0,0 +1,2 @@ +INSERT IGNORE INTO systempreferences (variable,value,explanation,options,type) VALUES ('NotifyToReturnItemWhenHoldIsPlaced', '0', 'If ON, notifies the patrons to return an item whenever a hold is placed on it', NULL, 'YesNo'); +INSERT IGNORE INTO systempreferences (variable,value,explanation,options,type) VALUES ('NotifyToReturnItemFromLibrary', 'ItemHomeLibrary', 'Restricts what library to take into consideration when notifying patrons to return items on hold', 'RequestorLibrary|ItemHomeLibrary|AnyLibrary', 'Choice'); diff --git a/installer/data/mysql/sysprefs.sql b/installer/data/mysql/sysprefs.sql index be111b6a65..e08a8658e1 100644 --- a/installer/data/mysql/sysprefs.sql +++ b/installer/data/mysql/sysprefs.sql @@ -312,6 +312,8 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` ('NoticeBcc','','','Email address to bcc outgoing notices sent by email','free'), ('NoticeCSS','',NULL,'Notices CSS url.','free'), ('NotifyBorrowerDeparture','30',NULL,'Define number of days before expiry where circulation is warned about patron account expiry','Integer'), +('NotifyToReturnItemFromLibrary','ItemHomeLibrary','RequestorLibrary|ItemHomeLibrary|AnyLibrary','Restricts what library to take into consideration when notifying patrons to return items on hold','Choice'), +('NotifyToReturnItemWhenHoldIsPlaced','0',NULL,'If ON, notifies the borrowers to return an item whenever a hold is placed on it','YesNo'), ('NovelistSelectEnabled','0',NULL,'Enable Novelist Select content. Requires Novelist Profile and Password','YesNo'), ('NovelistSelectPassword','',NULL,'Novelist select user Password','free'), ('NovelistSelectProfile','',NULL,'Novelist Select user Profile','free'), diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref index a1cd684a70..3904dfd06d 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref @@ -674,6 +674,18 @@ Circulation: no: "Don't enable" - "sending an email to the Koha administrator email address whenever a hold request is placed." - + - pref: NotifyToReturnItemWhenHoldIsPlaced + choices: + yes: Enable + no: "Don't enable" + - sending an email to the patrons to return an item whenever a hold request is placed on it. If enabled, contact patrons + - pref: NotifyToReturnItemFromLibrary + choices: + RequestorLibrary: "belonging to requestor's home library" + ItemHomeLibrary: "having the item borrowed from requestor's home library" + AnyLibrary: "from any library" + - . + - - pref: DisplayMultiPlaceHold choices: yes: Enable -- 2.11.0