Bugzilla – Attachment 86562 Details for
Bug 22489
Onboarding tool fails due to inserting maxissueqty into IssuingRule
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22489: (follow-up) Correctly set success messages
Bug-22489-follow-up-Correctly-set-success-messages.patch (text/plain), 2.31 KB, created by
Martin Renvoize
on 2019-03-13 09:39:28 UTC
(
hide
)
Description:
Bug 22489: (follow-up) Correctly set success messages
Filename:
MIME Type:
Creator:
Martin Renvoize
Created:
2019-03-13 09:39:28 UTC
Size:
2.31 KB
patch
obsolete
>From 35cc0f2800605b7026ed8e496b7d2485ecdcc3c9 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Wed, 13 Mar 2019 09:37:59 +0000 >Subject: [PATCH] Bug 22489: (follow-up) Correctly set success messages > >The original patch was duplicating the success message upon successful >circ rule insertion. This corrects that. > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > installer/onboarding.pl | 40 +++++++++++++++++++--------------------- > 1 file changed, 19 insertions(+), 21 deletions(-) > >diff --git a/installer/onboarding.pl b/installer/onboarding.pl >index aabb6b9014..4fe512a35b 100755 >--- a/installer/onboarding.pl >+++ b/installer/onboarding.pl >@@ -261,31 +261,29 @@ if ( $step == 5 ) { > my $issuingrule = Koha::IssuingRule->new($params); > eval { $issuingrule->store; }; > >- unless ($@) { >- push @messages, { code => 'success_on_insert_circ_rule' }; >- } >- else { >+ if ($@) { > push @messages, { code => 'error_on_insert_circ_rule' }; >- } >+ } else { > >- eval { >- Koha::CirculationRules->set_rules( >- { >- categorycode => $categorycode, >- itemtype => $itemtype, >- branchcode => $branchcode, >- rules => { >- maxissueqty => $maxissueqty, >+ eval { >+ Koha::CirculationRules->set_rules( >+ { >+ categorycode => $categorycode, >+ itemtype => $itemtype, >+ branchcode => $branchcode, >+ rules => { >+ maxissueqty => $maxissueqty, >+ } > } >- } >- ); >- }; >+ ); >+ }; > >- unless ($@) { >- push @messages, { code => 'success_on_insert_circ_rule' }; >- } >- else { >- push @messages, { code => 'error_on_insert_circ_rule' }; >+ unless ($@) { >+ push @messages, { code => 'success_on_insert_circ_rule' }; >+ } >+ else { >+ push @messages, { code => 'error_on_insert_circ_rule' }; >+ } > } > } > >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22489
:
86496
|
86497
|
86547
|
86561
|
86562
|
86577
|
86578
|
86632